From: Erik Faye-Lund <kusmabite@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: GIT Mailing-list <git@vger.kernel.org>,
Pat Thoyts <patthoyts@gmail.com>,
Marat Radchenko <marat@slonopotamus.org>,
tuomas.silvola@knowit.fi, msysGit <msysgit@googlegroups.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Dave Borowitz <dborowitz@google.com>
Subject: Re: [PATCH/RFC] Makefile: do not depend on curl-config
Date: Wed, 30 Apr 2014 15:08:14 +0200 [thread overview]
Message-ID: <CABPQNSbvoYfUp6ZG8kMPPX5rcDetUCqunOGO2cX-yhPsGkCOTg@mail.gmail.com> (raw)
In-Reply-To: <1398702545-9860-1-git-send-email-kusmabite@gmail.com>
On Mon, Apr 28, 2014 at 6:29 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
> MinGW builds of cURL does not ship with curl-config unless built
> with the autoconf based build system, which is not the practice
> recommended by the documentation. MsysGit has had issues with
> binaries of that sort, so it has switched away from autoconf-based
> cURL-builds.
>
> Unfortunately, broke pushing over WebDAV on Windows, because
> http-push.c depends on cURL's multi-threaded API, which we could
> not determine the presence of any more.
>
> Since troublesome curl-versions are ancient, and not even present
> in RedHat 5, let's just assume cURL is capable instead of doing a
> non-robust check.
>
> Instead, add a check for curl_multi_init to our configure-script,
> for those on ancient system. They probably already need to do the
> configure-dance anyway.
>
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Junio,
this patch still applies, and is required on Git for Windows for
http-push to work, even after f3f11fa ("Makefile: default to -lcurl
when no CURL_CONFIG or CURLDIR").
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2014-04-30 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 16:29 [PATCH/RFC] Makefile: do not depend on curl-config Erik Faye-Lund
2014-04-30 13:08 ` Erik Faye-Lund [this message]
2014-04-30 15:27 ` Junio C Hamano
2014-04-30 15:29 ` 'Dave Borowitz' via msysGit
2014-04-30 15:53 ` Erik Faye-Lund
2014-04-30 16:52 ` Johannes Schindelin
2014-04-30 19:46 ` Sebastian Schuberth
2014-05-05 10:53 ` Erik Faye-Lund
2014-05-05 10:56 ` Sebastian Schuberth
2014-05-05 15:03 ` [msysGit] " Thomas Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPQNSbvoYfUp6ZG8kMPPX5rcDetUCqunOGO2cX-yhPsGkCOTg@mail.gmail.com \
--to=kusmabite@gmail.com \
--cc=dborowitz@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=marat@slonopotamus.org \
--cc=msysgit@googlegroups.com \
--cc=patthoyts@gmail.com \
--cc=tuomas.silvola@knowit.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).