Git development
 help / color / mirror / Atom feed
From: Elijah Newren <newren@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 6/6] hex: allow only lowercase object IDs in breaking changes mode
Date: Tue, 25 Aug 2026 12:44:43 -0700	[thread overview]
Message-ID: <CABPp-BEAx+YZ547ig52EQaB65Yg6aEXb0qdLsWsChekhacqCSw@mail.gmail.com> (raw)
In-Reply-To: <20260729233215.398654-7-sandals@crustytoothpaste.net>

On Wed, Jul 29, 2026 at 4:33 PM brian m. carlson
<sandals@crustytoothpaste.net> wrote:
>
> In preparation for Git 3.0, only allow lowercase hex object IDs in
> breaking changes mode and document this as well.  Update the single
> failing test and add a new one to verify we reject new uppercase object
> IDs.  Note that in t5324, we change the hex character from "A" to "b"
> because in SHA-256 mode, "a" is the correct value, so our test_must_fail
> assertion will unexpectedly succeed in that case.
[...snip...]
> -               corrupt_file "$graphdir/commit-graph-chain" 30 "A" &&
> +               corrupt_file "$graphdir/commit-graph-chain" 30 "a" &&
[...]
> -               corrupt_file "$graphdir/commit-graph-chain" 70 "A" &&
> +               corrupt_file "$graphdir/commit-graph-chain" 70 "b" &&

which "A" is the commit message referring to?

> +* Git will accept hex object IDs only in lowercase. The fact that Git has
> +       historically allowed uppercase characters in hex object IDs has been the
> +       source of a variety of bugs and security problems in software using Git. We
> +       don't expect most users to notice any change.

You've indented with tabs here while the surrounding paragraphs use
spaces; is that going to mess up rendering?

  parent reply	other threads:[~2026-08-25 19:44 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 23:32 [RFC PATCH 0/6] Git 3.0: restrict hex object IDs to lowercase only brian m. carlson
2026-07-29 23:32 ` [RFC PATCH 1/6] hex: add functionality for lowercase-only hex brian m. carlson
2026-07-31  7:38   ` Junio C Hamano
2026-08-25 15:39   ` Junio C Hamano
2026-08-25 21:44     ` brian m. carlson
2026-07-29 23:32 ` [RFC PATCH 2/6] hex: allow specifying hex type with hex2chr brian m. carlson
2026-07-29 23:32 ` [RFC PATCH 3/6] hex: make hex_to_bytes accept kind of hex to use brian m. carlson
2026-07-31  7:38   ` Junio C Hamano
2026-08-01 14:35     ` Jeff King
2026-07-29 23:32 ` [RFC PATCH 4/6] hex: label usages of hex parsing for object IDs brian m. carlson
2026-07-31  3:24   ` Junio C Hamano
2026-08-25 16:11   ` Junio C Hamano
2026-07-29 23:32 ` [RFC PATCH 5/6] object-name: use hexval brian m. carlson
2026-08-25 16:19   ` Junio C Hamano
2026-08-25 19:44   ` Elijah Newren
2026-08-25 21:41     ` brian m. carlson
2026-07-29 23:32 ` [RFC PATCH 6/6] hex: allow only lowercase object IDs in breaking changes mode brian m. carlson
2026-07-31  7:48   ` Junio C Hamano
2026-07-31 12:33     ` Junio C Hamano
2026-08-02 22:09     ` brian m. carlson
2026-08-04 19:32       ` Junio C Hamano
2026-08-04 21:46         ` brian m. carlson
2026-08-05  3:09       ` Michael Montalbo
2026-08-25  9:04   ` Phillip Wood
2026-08-25 21:36     ` brian m. carlson
2026-08-25 16:36   ` Junio C Hamano
2026-08-25 19:44   ` Elijah Newren [this message]
2026-07-30  8:21 ` [RFC PATCH 0/6] Git 3.0: restrict hex object IDs to lowercase only Junio C Hamano
2026-07-30 21:18   ` brian m. carlson
2026-08-01 14:45     ` Jeff King
2026-08-01 18:22       ` Junio C Hamano
2026-08-02 21:55       ` brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABPp-BEAx+YZ547ig52EQaB65Yg6aEXb0qdLsWsChekhacqCSw@mail.gmail.com \
    --to=newren@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox