* [PATCH] fast-import: use mem_pool_calloc()
@ 2023-12-26 8:17 René Scharfe
2023-12-26 19:22 ` Elijah Newren
0 siblings, 1 reply; 2+ messages in thread
From: René Scharfe @ 2023-12-26 8:17 UTC (permalink / raw)
To: Git List
Use mem_pool_calloc() to get a zeroed buffer instead of zeroing it
ourselves. This makes the code clearer and less repetitive.
Signed-off-by: René Scharfe <l.s.r@web.de>
---
builtin/fast-import.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/builtin/fast-import.c b/builtin/fast-import.c
index 444f41cf8c..92eda20683 100644
--- a/builtin/fast-import.c
+++ b/builtin/fast-import.c
@@ -2809,8 +2809,7 @@ static void parse_new_tag(const char *arg)
enum object_type type;
const char *v;
- t = mem_pool_alloc(&fi_mem_pool, sizeof(struct tag));
- memset(t, 0, sizeof(struct tag));
+ t = mem_pool_calloc(&fi_mem_pool, 1, sizeof(struct tag));
t->name = mem_pool_strdup(&fi_mem_pool, arg);
if (last_tag)
last_tag->next_tag = t;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fast-import: use mem_pool_calloc()
2023-12-26 8:17 [PATCH] fast-import: use mem_pool_calloc() René Scharfe
@ 2023-12-26 19:22 ` Elijah Newren
0 siblings, 0 replies; 2+ messages in thread
From: Elijah Newren @ 2023-12-26 19:22 UTC (permalink / raw)
To: René Scharfe; +Cc: Git List
On Tue, Dec 26, 2023 at 12:18 AM René Scharfe <l.s.r@web.de> wrote:
>
> Use mem_pool_calloc() to get a zeroed buffer instead of zeroing it
> ourselves. This makes the code clearer and less repetitive.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> builtin/fast-import.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/builtin/fast-import.c b/builtin/fast-import.c
> index 444f41cf8c..92eda20683 100644
> --- a/builtin/fast-import.c
> +++ b/builtin/fast-import.c
> @@ -2809,8 +2809,7 @@ static void parse_new_tag(const char *arg)
> enum object_type type;
> const char *v;
>
> - t = mem_pool_alloc(&fi_mem_pool, sizeof(struct tag));
> - memset(t, 0, sizeof(struct tag));
> + t = mem_pool_calloc(&fi_mem_pool, 1, sizeof(struct tag));
> t->name = mem_pool_strdup(&fi_mem_pool, arg);
> if (last_tag)
> last_tag->next_tag = t;
> --
> 2.43.0
Makes sense; looks good to me.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-26 19:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-26 8:17 [PATCH] fast-import: use mem_pool_calloc() René Scharfe
2023-12-26 19:22 ` Elijah Newren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).