git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Hord <phil.hord@gmail.com>
To: git@vger.kernel.org, davvid@gmail.com
Subject: Re: MERGE_RR droppings
Date: Mon, 18 Jun 2012 18:41:05 -0400	[thread overview]
Message-ID: <CABURp0os2no40BW0P-biG_fXyi7MHRcLLYWmCbLTdBv1o1OXcg@mail.gmail.com> (raw)
In-Reply-To: <CABURp0omkVoLrz29GeOjjoZOpN238Rm6Nu5aOKQyVxFVnPihsw@mail.gmail.com>

git mergetool decides to use rerere-remaining based on the existence
of the .git/MERGE_RR file:

    if test -e "$GIT_DIR/MERGE_RR"
    then
        files=$(git rerere remaining)
    else
        files=$(git ls-files -u | sed -e 's/^[^ ]*      //' | sort -u)
    fi

But when I disabled rerere, I still had MERGE_RR files left over in my
.git directory.   This causes git-mergetool to do the wrong thing.

I do not know if the correct fix for this is to check rerere.enabled instead.

Is MERGE_RR leaking somewhere it should have been cleaned up?  I often
see leftover MERGE_RR files even though I am certain the project is
not in the middle of a merge.

Is this a bad semaphore to check?  I do not see it being used this way
anywhere else.


Phil

       reply	other threads:[~2012-06-18 22:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CABURp0omkVoLrz29GeOjjoZOpN238Rm6Nu5aOKQyVxFVnPihsw@mail.gmail.com>
2012-06-18 22:41 ` Phil Hord [this message]
2012-06-18 23:05   ` MERGE_RR droppings Junio C Hamano
2012-06-25 18:36     ` Phil Hord
2012-06-25 19:04     ` Junio C Hamano
2012-06-26  4:31       ` David Aguilar
2012-06-26  5:30         ` Junio C Hamano
2012-06-26 18:04   ` Junio C Hamano
2012-06-26 19:00     ` Phil Hord
2012-07-01  0:19       ` David Aguilar
2012-07-02  7:10         ` Junio C Hamano
2012-07-02 19:36           ` Phil Hord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABURp0os2no40BW0P-biG_fXyi7MHRcLLYWmCbLTdBv1o1OXcg@mail.gmail.com \
    --to=phil.hord@gmail.com \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).