git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ville Skyttä" <ville.skytta@iki.fi>
To: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] completion: complete --move for git branch
Date: Mon, 6 Jun 2016 19:19:00 +0300	[thread overview]
Message-ID: <CABr9L5AK5KhFvAW4dah3Hji_VStgYKesnD+Ljari7ihJX8Y7fg@mail.gmail.com> (raw)
In-Reply-To: <582640631.360243.1465222588996.JavaMail.zimbra@ensimag.grenoble-inp.fr>

On Mon, Jun 6, 2016 at 5:16 PM, Remi Galan Alfonso
<remi.galan-alfonso@ensimag.grenoble-inp.fr> wrote:
>
> Hi,
>
> Ville Skyttä <ville.skytta@iki.fi> writes:
> >          while [ $c -lt $cword ]; do
> >                  i="${words[c]}"
> >                  case "$i" in
> > -                -d|-m)        only_local_ref="y" ;;
> > -                -r)        has_r="y" ;;
> > +                -d|-m|--move)        only_local_ref="y" ;;
>
> "While you're at it" you might want to do the same thing for
> `--delete`.

I'm afraid the "while I'm at it" would never end if I start looking
deeper into missing things there, so I'd prefer this self contained
one I keep running into myself applied first.

> > +                -r)                has_r="y" ;;
>
> You are introducing an additional tab here that you probably didn't
> want.

It was intentionally added it to keep "only_local_ref" and "has_r"
tab-aligned the way they already were.

  reply	other threads:[~2016-06-06 16:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 13:16 [PATCH] completion: complete --move for git branch Ville Skyttä
2016-06-06 14:16 ` Remi Galan Alfonso
2016-06-06 16:19   ` Ville Skyttä [this message]
2016-06-07  9:16     ` Remi Galan Alfonso
2016-08-09  9:34       ` [PATCH v2] completion: complete --delete, --move, and --remotes " Ville Skyttä
2016-08-09 18:30         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABr9L5AK5KhFvAW4dah3Hji_VStgYKesnD+Ljari7ihJX8Y7fg@mail.gmail.com \
    --to=ville.skytta@iki.fi \
    --cc=git@vger.kernel.org \
    --cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).