From: Francis Moreau <francis.moro@gmail.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: git@vger.kernel.org
Subject: Re: git submodule summary doesn't return an error when passed a wrong commit/rev
Date: Fri, 26 Oct 2012 21:56:02 +0200 [thread overview]
Message-ID: <CAC9WiBj8-TmJmOowcA2KK7xYVoGoVZ8NoeTdRP9Qj6_RYr0ChQ@mail.gmail.com> (raw)
In-Reply-To: <508AEA39.2020205@web.de>
On Fri, Oct 26, 2012 at 9:53 PM, Jens Lehmann <Jens.Lehmann@web.de> wrote:
> Am 26.10.2012 16:03, schrieb Francis Moreau:
>> it seems to me that when passed an unknown rev or a wrong commit/sha1,
>> git-submodule-summary should at least exit with an error status. Even better
>> would be a error output.
>>
>> Test was done with git version 1.7.10.4 from debian wheezy.
>
> Thanks for your report, I think you found a real issue. Some quick
> tests showed some problems with other parameter combinations too.
> I'll take a deeper look the next days.
Glad to help :)
--
Francis
prev parent reply other threads:[~2012-10-26 19:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 14:03 git submodule summary doesn't return an error when passed a wrong commit/rev Francis Moreau
2012-10-26 19:53 ` Jens Lehmann
2012-10-26 19:56 ` Francis Moreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC9WiBj8-TmJmOowcA2KK7xYVoGoVZ8NoeTdRP9Qj6_RYr0ChQ@mail.gmail.com \
--to=francis.moro@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).