* git submodule summary doesn't return an error when passed a wrong commit/rev
@ 2012-10-26 14:03 Francis Moreau
2012-10-26 19:53 ` Jens Lehmann
0 siblings, 1 reply; 3+ messages in thread
From: Francis Moreau @ 2012-10-26 14:03 UTC (permalink / raw)
To: git
Hi,
it seems to me that when passed an unknown rev or a wrong commit/sha1,
git-submodule-summary should at least exit with an error status. Even better
would be a error output.
Test was done with git version 1.7.10.4 from debian wheezy.
Thanks
--
Francis
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: git submodule summary doesn't return an error when passed a wrong commit/rev
2012-10-26 14:03 git submodule summary doesn't return an error when passed a wrong commit/rev Francis Moreau
@ 2012-10-26 19:53 ` Jens Lehmann
2012-10-26 19:56 ` Francis Moreau
0 siblings, 1 reply; 3+ messages in thread
From: Jens Lehmann @ 2012-10-26 19:53 UTC (permalink / raw)
To: Francis Moreau; +Cc: git
Am 26.10.2012 16:03, schrieb Francis Moreau:
> it seems to me that when passed an unknown rev or a wrong commit/sha1,
> git-submodule-summary should at least exit with an error status. Even better
> would be a error output.
>
> Test was done with git version 1.7.10.4 from debian wheezy.
Thanks for your report, I think you found a real issue. Some quick
tests showed some problems with other parameter combinations too.
I'll take a deeper look the next days.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: git submodule summary doesn't return an error when passed a wrong commit/rev
2012-10-26 19:53 ` Jens Lehmann
@ 2012-10-26 19:56 ` Francis Moreau
0 siblings, 0 replies; 3+ messages in thread
From: Francis Moreau @ 2012-10-26 19:56 UTC (permalink / raw)
To: Jens Lehmann; +Cc: git
On Fri, Oct 26, 2012 at 9:53 PM, Jens Lehmann <Jens.Lehmann@web.de> wrote:
> Am 26.10.2012 16:03, schrieb Francis Moreau:
>> it seems to me that when passed an unknown rev or a wrong commit/sha1,
>> git-submodule-summary should at least exit with an error status. Even better
>> would be a error output.
>>
>> Test was done with git version 1.7.10.4 from debian wheezy.
>
> Thanks for your report, I think you found a real issue. Some quick
> tests showed some problems with other parameter combinations too.
> I'll take a deeper look the next days.
Glad to help :)
--
Francis
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-26 19:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-26 14:03 git submodule summary doesn't return an error when passed a wrong commit/rev Francis Moreau
2012-10-26 19:53 ` Jens Lehmann
2012-10-26 19:56 ` Francis Moreau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).