git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Angelo Borsotti <angelo.borsotti@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: push race
Date: Mon, 15 Oct 2012 16:09:40 +0200	[thread overview]
Message-ID: <CACBZZX5keWVDZ-rvQfHFChKRC1YwXcUvfiqzgeMjVTydnQCdmg@mail.gmail.com> (raw)
In-Reply-To: <CAB9Jk9Be4gGaBXixWN7Xju7N6RGKH+FonhaTbZFJ6uYsJDk8dg@mail.gmail.com>

On Mon, Oct 15, 2012 at 11:14 AM, Angelo Borsotti
<angelo.borsotti@gmail.com> wrote:
> Hello,

FWIW we have a lot of lemmings pushing to the same ref all the time at
$work, and while I've seen cases where:

 1. Two clients try to push
 2. They both get the initial lock
 3. One of them fails to get the secondary lock (I think updating the ref)

I've never seen cases where they clobber each other in #3 (and I would
have known from "dude, where's my commit that I just pushed" reports).

So while we could fix git to make sure there's no race condition such
that two clients never get the #2 lock I haven't seen it cause actual
data issues because of two clients getting the #3 lock.

It might still happen in some cases, I recommend testing it with e.g.
lots of pushes in parallel with GNU Parallel.

  parent reply	other threads:[~2012-10-15 14:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-15  9:14 push race Angelo Borsotti
2012-10-15 11:05 ` Matthieu Moy
2012-10-15 11:53   ` Nguyen Thai Ngoc Duy
     [not found] ` <CAPc5daUon3eLTDT=3wo_=rTCJWVe=ufCvmSzrjD=0T17Dxkpqw@mail.gmail.com>
2012-10-15 11:50   ` Angelo Borsotti
2012-10-15 14:09 ` Ævar Arnfjörð Bjarmason [this message]
2012-10-15 14:13   ` demerphq
2012-10-15 14:29   ` Marc Branchaud
2012-10-15 15:50     ` Angelo Borsotti
2012-10-15 18:58       ` Jeff King
2012-10-15 18:56     ` Jeff King
2012-10-16  2:09       ` Shawn Pearce
2012-10-16  4:51         ` Jeff King
2012-10-16  5:15           ` Nguyen Thai Ngoc Duy
2012-10-16  5:37             ` Jeff King
2012-10-16 10:45               ` Nguyen Thai Ngoc Duy
2012-10-16 17:02                 ` Jeff King
2012-10-16 17:21                 ` Junio C Hamano
2012-10-16 17:25                   ` Jeff King
2012-10-16 19:09                     ` Junio C Hamano
2012-10-16  6:35       ` Angelo Borsotti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACBZZX5keWVDZ-rvQfHFChKRC1YwXcUvfiqzgeMjVTydnQCdmg@mail.gmail.com \
    --to=avarab@gmail.com \
    --cc=angelo.borsotti@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).