From: Paul Tan <pyokagan@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: Stefan Beller <sbeller@google.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Paul Tan <pyokagan@gmail.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: [PATCH v3 4/9] t5520: test for failure if index has unresolved entries
Date: Fri, 15 May 2015 16:25:02 +0800 [thread overview]
Message-ID: <CACRoPnR_tKfSPpRDnQ6_z+XECe7phaN1zRWDZxoaRAz6egGcNw@mail.gmail.com> (raw)
In-Reply-To: <1431508136-15313-5-git-send-email-pyokagan@gmail.com>
On Wed, May 13, 2015 at 5:08 PM, Paul Tan <pyokagan@gmail.com> wrote:
> +test_expect_success 'fail if the index has unresolved entries' '
> + git checkout -b third second^ &&
> + test_when_finished "git checkout -f copy && git branch -D third" &&
> + verbose test "$(cat file)" = file &&
> + echo modified2 >file &&
> + git commit -a -m modified2 &&
> + verbose test -z "$(git ls-files -u)" &&
> + test_must_fail git pull . second &&
> + verbose test -n "$(git ls-files -u)" &&
> + cp file expected &&
> + test_must_fail git pull . second 2>err &&
> + test_i18ngrep "you have unmerged files" err &&
Hmm, it appears that this is too loose, as git-merge will throw "merge
is not possible because you have unmerged files".
So it looks like we will have to go back to the stricter "Pull is not
possible because you have unmerged files".
> + test_cmp expected file &&
> + git add file &&
> + verbose test -z "$(git ls-files -u)" &&
> + test_must_fail git pull . second 2>err &&
> + test_i18ngrep "have not concluded your merge" err &&
> + test_cmp expected file
> +'
> +
> test_expect_success '--rebase' '
> git branch to-rebase &&
> echo modified again > file &&
> --
> 2.1.4
>
next prev parent reply other threads:[~2015-05-15 8:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 9:08 [PATCH v3 0/9] Improve git-pull test coverage Paul Tan
2015-05-13 9:08 ` [PATCH v3 1/9] t5520: fixup file contents comparisons Paul Tan
2015-05-13 14:01 ` Junio C Hamano
2015-05-13 14:42 ` Junio C Hamano
2015-05-14 17:29 ` Michael Blume
2015-05-14 17:44 ` Junio C Hamano
2015-05-15 11:41 ` Paul Tan
2015-05-15 18:37 ` Junio C Hamano
2015-05-15 19:22 ` Junio C Hamano
2015-05-16 13:49 ` Paul Tan
2015-05-16 18:57 ` Junio C Hamano
2015-05-16 23:32 ` Junio C Hamano
2015-05-17 7:47 ` Paul Tan
2015-05-13 9:08 ` [PATCH v3 2/9] t5520: ensure origin refs are updated Paul Tan
2015-05-13 14:27 ` Junio C Hamano
2015-05-18 13:09 ` Paul Tan
2015-05-13 9:08 ` [PATCH v3 3/9] t5520: test no merge candidates cases Paul Tan
2015-05-13 9:08 ` [PATCH v3 4/9] t5520: test for failure if index has unresolved entries Paul Tan
2015-05-13 9:32 ` Matthieu Moy
2015-05-15 8:25 ` Paul Tan [this message]
2015-05-13 9:08 ` [PATCH v3 5/9] t5520: test work tree fast-forward when fetch updates head Paul Tan
2015-05-13 9:08 ` [PATCH v3 6/9] t5520: test --rebase with multiple branches Paul Tan
2015-05-13 9:08 ` [PATCH v3 7/9] t5520: test --rebase failure on unborn branch with index Paul Tan
2015-05-13 9:08 ` [PATCH v3 8/9] t5521: test --dry-run does not make any changes Paul Tan
2015-05-13 9:08 ` [PATCH v3 9/9] t5520: check reflog action in fast-forward merge Paul Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRoPnR_tKfSPpRDnQ6_z+XECe7phaN1zRWDZxoaRAz6egGcNw@mail.gmail.com \
--to=pyokagan@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).