From: Paul Tan <pyokagan@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Jeff King <peff@peff.net>, Paul Tan <pyokagan@gmail.com>
Subject: Re: [PATCH v2 2/4] git-credential-store: support XDG_CONFIG_HOME
Date: Tue, 10 Mar 2015 21:43:03 +0800 [thread overview]
Message-ID: <CACRoPnRoY=c5NukCCS0OPMaL1TvqSuSL036-mK+4sae_6VgrVA@mail.gmail.com> (raw)
In-Reply-To: <1425801532-8483-3-git-send-email-pyokagan@gmail.com>
On Sun, Mar 8, 2015 at 3:58 PM, Paul Tan <pyokagan@gmail.com> wrote:
> remove_credential(&fns, &c);
> else if (!strcmp(op, "store"))
> - store_credential(&fns, &c, fns.nr - 1);
> + store_credential(&fns, &c, 0);
> else
> ; /* Ignore unknown operation. */
Whoops, seems like I squashed some commits in the wrong order (but
there is no functional difference). Will re-roll the patch series.
Also, store_credential() should take a string as the default filename
instead of an index into the filename string_list for extra API
flexibility.
Thanks.
next prev parent reply other threads:[~2015-03-10 13:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 7:58 [PATCH v2 0/4] git-credential-store: XDG user-specific config file support Paul Tan
2015-03-08 7:58 ` [PATCH v2 1/4] git-credential-store: support multiple credential files Paul Tan
2015-03-08 7:58 ` [PATCH v2 2/4] git-credential-store: support XDG_CONFIG_HOME Paul Tan
2015-03-10 13:43 ` Paul Tan [this message]
2015-03-08 7:58 ` [PATCH v2 3/4] docs/git-credential-store: document XDG file and precedence Paul Tan
2015-03-08 7:58 ` [PATCH v2 4/4] t0302: test credential-store support for XDG_CONFIG_HOME Paul Tan
2015-03-09 12:36 ` Matthieu Moy
2015-03-10 13:55 ` Paul Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRoPnRoY=c5NukCCS0OPMaL1TvqSuSL036-mK+4sae_6VgrVA@mail.gmail.com' \
--to=pyokagan@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).