From: Carsten Mattner <carstenmattner@googlemail.com>
To: Jeff King <peff@peff.net>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/2] completion: backwards compatibility fix
Date: Sat, 19 May 2012 09:54:28 +0200 [thread overview]
Message-ID: <CACY+Hvp-G4odbftiFeu1u+1icROD36M=CzSn3DKu_TEaqNB3OQ@mail.gmail.com> (raw)
In-Reply-To: <20120519024503.GA2801@sigill.intra.peff.net>
On Sat, May 19, 2012 at 4:45 AM, Jeff King <peff@peff.net> wrote:
> On Sat, May 19, 2012 at 04:41:33AM +0200, Felipe Contreras wrote:
>
>> These two patches are meant to fix the backwards compatibility of _git, and
>> _gitk. This also helps my zsh's wrapper.
>>
>> Felipe Contreras (2):
>> completion: rename _git and _gitk
>> completion: add support for backwards compatibilit
>
> Thanks. This looks like the obviously correct solution. Even if we end
> up with a public _GIT_complete or whatever, the backwards-compatibility
> is worth it.
Cool. Just though the patches now. Felipe, which variant should I use
to define _main_git completion for the alias g with the 2 patches
applied to git_completion.bash? Using bash-4.2.28.
next prev parent reply other threads:[~2012-05-19 7:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-19 2:41 [PATCH 0/2] completion: backwards compatibility fix Felipe Contreras
2012-05-19 2:41 ` [PATCH 1/2] completion: rename _git and _gitk Felipe Contreras
2012-05-22 8:24 ` SZEDER Gábor
2012-05-22 18:00 ` Junio C Hamano
2012-05-22 18:52 ` Felipe Contreras
2012-05-19 2:41 ` [PATCH 2/2] completion: add support for backwards compatibility Felipe Contreras
2012-05-19 2:45 ` [PATCH 0/2] completion: backwards compatibility fix Jeff King
2012-05-19 7:54 ` Carsten Mattner [this message]
2012-05-19 15:31 ` Jeff King
2012-05-19 17:45 ` Carsten Mattner
2012-05-20 5:11 ` Junio C Hamano
2012-05-20 9:02 ` Carsten Mattner
2012-05-20 10:28 ` Felipe Contreras
2012-05-20 17:27 ` Carsten Mattner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACY+Hvp-G4odbftiFeu1u+1icROD36M=CzSn3DKu_TEaqNB3OQ@mail.gmail.com' \
--to=carstenmattner@googlemail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).