git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fix minor typo in hook documentation
@ 2016-02-24 12:51 Martin Amdisen
  2016-02-24 18:07 ` Eric Sunshine
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Amdisen @ 2016-02-24 12:51 UTC (permalink / raw)
  To: git

>From 3f8fd9e5771791a18e89fdb1f1a681eb6fc66ad1 Mon Sep 17 00:00:00 2001
From: Martin Mosegaard Amdisen <martin.amdisen@praqma.com>
Date: Wed, 24 Feb 2016 08:43:07 +0100
Subject: [PATCH] Fix minor typo in hook documentation

---
 templates/hooks--update.sample | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/templates/hooks--update.sample b/templates/hooks--update.sample
index d847583..80ba941 100755
--- a/templates/hooks--update.sample
+++ b/templates/hooks--update.sample
@@ -1,6 +1,6 @@
 #!/bin/sh
 #
-# An example hook script to blocks unannotated tags from entering.
+# An example hook script to block unannotated tags from entering.
 # Called by "git receive-pack" with arguments: refname sha1-old sha1-new
 #
 # To enable this hook, rename this file to "update".
--
2.6.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix minor typo in hook documentation
  2016-02-24 12:51 [PATCH] Fix minor typo in hook documentation Martin Amdisen
@ 2016-02-24 18:07 ` Eric Sunshine
  0 siblings, 0 replies; 3+ messages in thread
From: Eric Sunshine @ 2016-02-24 18:07 UTC (permalink / raw)
  To: Martin Amdisen; +Cc: Git List

Thanks for the submission. See review comments below...

On Wed, Feb 24, 2016 at 7:51 AM, Martin Amdisen
<martin.amdisen@praqma.com> wrote:
> From 3f8fd9e5771791a18e89fdb1f1a681eb6fc66ad1 Mon Sep 17 00:00:00 2001
> From: Martin Mosegaard Amdisen <martin.amdisen@praqma.com>
> Date: Wed, 24 Feb 2016 08:43:07 +0100
> Subject: [PATCH] Fix minor typo in hook documentation

When you re-roll, drop these four lines. The first is only meaningful
in your own local repository, and the rest are picked up automatically
from the email envelope.

Your Signed-off-by: is missing. See Documentation/SubmittingPatches.

The patch itself looks good.

> ---
> diff --git a/templates/hooks--update.sample b/templates/hooks--update.sample
> index d847583..80ba941 100755
> --- a/templates/hooks--update.sample
> +++ b/templates/hooks--update.sample
> @@ -1,6 +1,6 @@
>  #!/bin/sh
>  #
> -# An example hook script to blocks unannotated tags from entering.
> +# An example hook script to block unannotated tags from entering.
>  # Called by "git receive-pack" with arguments: refname sha1-old sha1-new
>  #
>  # To enable this hook, rename this file to "update".
> --

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] Fix minor typo in hook documentation
@ 2016-02-25  8:10 Martin Amdisen
  0 siblings, 0 replies; 3+ messages in thread
From: Martin Amdisen @ 2016-02-25  8:10 UTC (permalink / raw)
  To: git

Signed-off-by: Martin Mosegaard Amdisen <martin.amdisen@praqma.com>
---
 templates/hooks--update.sample | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/templates/hooks--update.sample b/templates/hooks--update.sample
index d847583..80ba941 100755
--- a/templates/hooks--update.sample
+++ b/templates/hooks--update.sample
@@ -1,6 +1,6 @@
 #!/bin/sh
 #
-# An example hook script to blocks unannotated tags from entering.
+# An example hook script to block unannotated tags from entering.
 # Called by "git receive-pack" with arguments: refname sha1-old sha1-new
 #
 # To enable this hook, rename this file to "update".
--
2.6.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-25  8:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-24 12:51 [PATCH] Fix minor typo in hook documentation Martin Amdisen
2016-02-24 18:07 ` Eric Sunshine
  -- strict thread matches above, loose matches on Subject: below --
2016-02-25  8:10 Martin Amdisen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).