From: Duy Nguyen <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org, Jens Lehmann <Jens.Lehmann@web.de>,
Heiko Voigt <hvoigt@hvoigt.net>,
Manlio Perillo <manlio.perillo@gmail.com>,
"W. Trevor King" <wking@drexel.edu>
Subject: Re: [PATCH] clone: forbid --bare --separate-git-dir <dir>
Date: Mon, 7 Jan 2013 08:18:43 +0700 [thread overview]
Message-ID: <CACsJy8A6soMEJ3FXY8MyeERAGN483M2UjqRS4muzzD6uj1QWow@mail.gmail.com> (raw)
In-Reply-To: <7v6239nbw0.fsf@alter.siamese.dyndns.org>
On Mon, Jan 7, 2013 at 6:13 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> I don't know what would go in the <explanation here> blank above,
>> though. Is it possible that some people are relying on this option
>> combination?
>
> I do not necessarily think we must say "it happens not to work
> already for such and such reasons, lucky us!", but it is indeed a
> good idea to think things through, justifying why this cannot be a
> regression, and record the fact that we did that thinking, in the
> log message.
>
> Thanks.
I wanted to give a day or two or think about the <explanation here>.
Does "Thanks." mean you have picked up the patch and adjusted the
commit message appropriately, or should I go with my original plan and
resend it later with "explanantion there"?
--
Duy
next prev parent reply other threads:[~2013-01-07 1:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 20:53 [BUG] git submodule update is not fail safe Manlio Perillo
2013-01-04 21:51 ` Junio C Hamano
2013-01-05 13:52 ` Manlio Perillo
2013-01-05 14:07 ` Jens Lehmann
2013-01-05 14:01 ` Jens Lehmann
2013-01-05 14:49 ` Manlio Perillo
2013-01-05 14:50 ` Jens Lehmann
2013-01-05 20:17 ` [PATCH] clone: support atomic operation with --separate-git-dir Jens Lehmann
2013-01-05 21:20 ` Manlio Perillo
2013-01-06 6:43 ` Junio C Hamano
2013-01-06 8:49 ` Duy Nguyen
2013-01-06 9:16 ` Jonathan Nieder
2013-01-06 9:47 ` [PATCH] clone: forbid --bare --separate-git-dir <dir> Nguyễn Thái Ngọc Duy
2013-01-06 10:19 ` Jonathan Nieder
2013-01-06 23:13 ` Junio C Hamano
2013-01-07 1:18 ` Duy Nguyen [this message]
2013-01-07 2:04 ` Junio C Hamano
2013-01-08 14:16 ` Duy Nguyen
2013-01-08 17:15 ` Jens Lehmann
2013-01-08 17:45 ` Junio C Hamano
2013-01-08 23:34 ` Duy Nguyen
2013-01-08 23:42 ` Junio C Hamano
2013-01-11 3:09 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2013-01-11 3:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8A6soMEJ3FXY8MyeERAGN483M2UjqRS4muzzD6uj1QWow@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=jrnieder@gmail.com \
--cc=manlio.perillo@gmail.com \
--cc=wking@drexel.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).