From: Duy Nguyen <pclouds@gmail.com>
To: Karsten Blees <karsten.blees@gmail.com>
Cc: Git List <git@vger.kernel.org>,
msysGit <msysgit@googlegroups.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v5 00/11] add performance tracing facility
Date: Thu, 26 Jun 2014 08:11:44 +0700 [thread overview]
Message-ID: <CACsJy8AoDJLMbhG82AMnt61hK_DoXQ16SY_M2J_XnUuTamv0qQ@mail.gmail.com> (raw)
In-Reply-To: <53AAE17A.7050500@gmail.com>
On Wed, Jun 25, 2014 at 9:49 PM, Karsten Blees <karsten.blees@gmail.com> wrote:
> Am 25.06.2014 16:28, schrieb Duy Nguyen:
>> On Wed, Jun 11, 2014 at 2:55 PM, Karsten Blees <karsten.blees@gmail.com> wrote:
>>> Here's v5 of the performance tracing patch series, now including a bunch of cleanups and adding timestamp, file and line to all trace output.
>>>
>>> I'm particularly interested in feedback for the output format. As file names have different lengths, printing file:line as prefix results in unaligned output:
>>>
>>> > GIT_TRACE=1 git stash list
>>> 00:12:10.544266 git.c:512 trace: exec: 'git-stash' 'list'
>>> 00:12:10.544266 run-command.c:337 trace: run_command: 'git-stash' 'list'
>>> 00:12:10.649779 git.c:312 trace: built-in: git 'rev-parse' '--git-dir'
>>
>> Can I have an (build-time) option to show <function>:<line> instead of
>> <file>:<line>? I know it's not supported by all compilers, which may
>> make support a bit cumbersome..
>>
>
> Is this really useful? <file>:<line> is unique, but <function>:<line> is not. E.g. in case of "hash_name:47" you'd have to guess if its the one in attr.c or name-hash.c...
It depends on your view. If I'm tracing a certain operation, function
names let me know roughly what's going on without looking at the code
because all (or many of) the names and their purposes are already in
my mind. But for publishing the traces, then I agree <file>:<line> is
better.
--
Duy
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
prev parent reply other threads:[~2014-06-26 1:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 7:55 [PATCH v5 00/11] add performance tracing facility Karsten Blees
2014-06-11 7:56 ` [PATCH v5 01/11] trace: move trace declarations from cache.h to new trace.h Karsten Blees
2014-06-11 7:57 ` [PATCH v5 02/11] trace: consistently name the format parameter Karsten Blees
2014-06-11 7:57 ` [PATCH v5 03/11] trace: remove redundant printf format attribute Karsten Blees
2014-06-11 7:58 ` [PATCH v5 04/11] trace: factor out printing to the trace file Karsten Blees
2014-06-11 7:59 ` [PATCH v5 05/11] trace: add infrastructure to augment trace output with additional info Karsten Blees
2014-06-11 7:59 ` [PATCH v5 06/11] trace: add current timestamp to all trace output Karsten Blees
2014-06-11 8:00 ` [PATCH v5 07/11] trace: move code around, in preparation to file:line output Karsten Blees
2014-06-11 8:00 ` [PATCH v5 08/11] trace: add 'file:line' to all trace output Karsten Blees
2014-06-11 8:01 ` [PATCH v5 09/11] trace: add high resolution timer function to debug performance issues Karsten Blees
2014-06-11 8:12 ` Karsten Blees
2014-06-17 16:44 ` Junio C Hamano
2014-06-18 15:14 ` Karsten Blees
2014-06-11 8:01 ` [PATCH v5 10/11] trace: add trace_performance facility " Karsten Blees
2014-06-17 17:11 ` Junio C Hamano
2014-06-18 15:14 ` Karsten Blees
2014-06-18 17:28 ` Junio C Hamano
2014-06-11 8:02 ` [PATCH v5 11/11] git: add performance tracing for git's main() function to debug scripts Karsten Blees
2014-06-12 18:30 ` [PATCH v5 00/11] add performance tracing facility Junio C Hamano
2014-06-18 15:14 ` Karsten Blees
2014-06-25 14:28 ` Duy Nguyen
2014-06-25 14:49 ` Karsten Blees
2014-06-26 1:11 ` Duy Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8AoDJLMbhG82AMnt61hK_DoXQ16SY_M2J_XnUuTamv0qQ@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=karsten.blees@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).