From: Duy Nguyen <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] unpack-trees: do not abort when overwriting an existing file with the same content
Date: Mon, 21 Jan 2013 08:35:44 +0700 [thread overview]
Message-ID: <CACsJy8C-vRVsC5uj8xqucwMBZ2TEtwSF-58xM2oTSp6RtNAWMg@mail.gmail.com> (raw)
In-Reply-To: <7va9s3n1my.fsf@alter.siamese.dyndns.org>
On Mon, Jan 21, 2013 at 1:35 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>> + /*
>> + * If it has the same content that we are going to write down,
>
> write down???
hmm.. "overwrite" then.
>> + * there's no point in complaining. We still overwrite it in the
>> + * end though. Permission is not checked so it may be lost.
>> + */
>
> That is a regression, isn't it? Is it too cumbersome to avoid
> losing the permission bits by stopping in that case?
I'm not sure how to deal with this case. (Lack of) Executable bit can
be easily restored (unlike file content) if we give the user the list
of changed files. On the other hand, not everybody runs git with a
huge scrollback buffer and warnings can be lost. I guess abort is a
safe choice.
--
Duy
next prev parent reply other threads:[~2013-01-21 1:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 11:24 [PATCH] unpack-trees: do not abort when overwriting an existing file with the same content Nguyễn Thái Ngọc Duy
2013-01-20 18:35 ` Junio C Hamano
2013-01-21 1:35 ` Duy Nguyen [this message]
2013-01-21 11:40 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2013-01-21 23:15 ` Jeff King
2013-01-22 0:59 ` Duy Nguyen
2013-01-22 1:45 ` Junio C Hamano
2013-01-22 1:55 ` Duy Nguyen
2013-01-22 20:19 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8C-vRVsC5uj8xqucwMBZ2TEtwSF-58xM2oTSp6RtNAWMg@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).