From: Duy Nguyen <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jean-Noël AVILA" <avila.jn@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] attr: fix off-by-one directory component length calculation
Date: Wed, 16 Jan 2013 10:12:16 +0700 [thread overview]
Message-ID: <CACsJy8C2uEgwozpWBfowYJea3XRB72rhzjsSFuG9Ud0afuQy6w@mail.gmail.com> (raw)
In-Reply-To: <7vbocp26xa.fsf@alter.siamese.dyndns.org>
On Wed, Jan 16, 2013 at 9:33 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Duy Nguyen <pclouds@gmail.com> writes:
>
>> On Wed, Jan 16, 2013 at 08:08:03AM +0700, Duy Nguyen wrote:
>>> Actually I'd like to remove that function.
>>
>> This is what I had in mind:
>
> I think the replacement logic to find the basename is moderately
> inferiour to the original. For one thing (this may be somewhat
> subjective), it is less readable now.
Yeah, maybe it's micro optimization.
> Also the original only
> scanned the string from the beginning once (instead of letting
> strlen() to scan once and go back).
But we do need to strlen() anyway in collect_all_attrs(). So we scan
the string 3 times (strlen + 2 * find_basename) in the original. Now
we do it twice
--
Duy
next prev parent reply other threads:[~2013-01-16 3:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 13:35 [PATCH] attr: fix off-by-one directory component length calculation Nguyễn Thái Ngọc Duy
2013-01-15 16:17 ` Junio C Hamano
2013-01-15 19:14 ` Jean-Noël AVILA
2013-01-15 19:29 ` Junio C Hamano
2013-01-15 19:53 ` Jean-Noël AVILA
2013-01-15 20:49 ` Junio C Hamano
2013-01-15 23:24 ` Jeff King
2013-01-16 6:15 ` t9902 fails (Was: [PATCH] attr: fix off-by-one directory component length calculation) Torsten Bögershausen
2013-01-17 22:47 ` Jean-Noël AVILA
2013-01-18 0:04 ` Jonathan Nieder
2013-01-18 0:12 ` t9902 fails Junio C Hamano
2013-01-18 5:20 ` t9902 fails (Was: [PATCH] attr: fix off-by-one directory component length calculation) Torsten Bögershausen
2013-01-18 16:49 ` t9902 fails Junio C Hamano
2013-01-18 20:15 ` Junio C Hamano
2013-01-18 22:23 ` Jean-Noël AVILA
2013-01-18 22:37 ` Junio C Hamano
2013-01-18 22:57 ` Junio C Hamano
2013-01-19 5:38 ` Torsten Bögershausen
2013-01-19 7:52 ` Re* " Junio C Hamano
2013-01-19 8:00 ` [PATCH 1/2] help: include <common-cmds.h> only in one file Junio C Hamano
2013-01-19 8:02 ` [PATCH 2/2] help --standard: list standard commands Junio C Hamano
2013-01-19 10:32 ` Jean-Noël AVILA
2013-01-19 13:43 ` Re* t9902 fails Jean-Noël AVILA
2013-01-19 10:23 ` Jean-Noël AVILA
2013-01-16 1:08 ` [PATCH] attr: fix off-by-one directory component length calculation Duy Nguyen
2013-01-16 2:09 ` Duy Nguyen
2013-01-16 2:33 ` Junio C Hamano
2013-01-16 3:12 ` Duy Nguyen [this message]
2013-01-16 5:35 ` Junio C Hamano
2013-01-16 6:02 ` Duy Nguyen
2013-01-16 19:07 ` Junio C Hamano
2013-01-16 1:03 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8C2uEgwozpWBfowYJea3XRB72rhzjsSFuG9Ud0afuQy6w@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=avila.jn@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).