From: Duy Nguyen <pclouds@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Xin Jiang <worldhello.net@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>
Subject: Re: [BUG] git_path() returns relative paths
Date: Sat, 27 Jul 2013 22:17:17 +0700 [thread overview]
Message-ID: <CACsJy8CDg2ORKrpwiph=WdW5GPUYEwT1CSCttQ4fagQoMP4QGA@mail.gmail.com> (raw)
In-Reply-To: <CALkWK0kWnge7fVtTXRgTiK1NbyN8X=bmqfPTc+Mp=BCssPc1og@mail.gmail.com>
On Sat, Jul 27, 2013 at 9:33 PM, Ramkumar Ramachandra
<artagnon@gmail.com> wrote:
> Duy Nguyen wrote:
>> 044bbbc (Make git_dir a path relative to work_tree in
>> setup_work_tree() - 2008-06-19)
>
> Okay, so it does seem to be a significant optimization. Frankly,
> e02ca72 only improves the relative_path() algorithm, and it's not
> really doing anything Wrong: it's has just uncovered a previously
> undiscovered bug.
>
> So far, we know that the line:
>
> s->fp = fopen(git_path(commit_editmsg), "w");
>
> in commit.c:prepare_to_commit() isn't failing; so, the work_tree and
> git_dir do seem to be set correctly. The problem seems to be in
> launch_editor(). What's worse? Everything works just fine when I have
> a symbolic link to a directory in a normal repository; I still can't
> figure out what submodules have to do with any of this.
>
> What the hell is going on?!
I was involved with this code (the gitdir setup code, not submodule)
and am interested to know what's going on too. Could you produce a
small script to reproduce it?
--
Duy
next prev parent reply other threads:[~2013-07-27 15:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-27 11:10 [BUG] git_path() returns relative paths Ramkumar Ramachandra
2013-07-27 11:48 ` Duy Nguyen
2013-07-27 12:05 ` Ramkumar Ramachandra
2013-07-27 12:31 ` Ramkumar Ramachandra
2013-07-27 12:47 ` Duy Nguyen
2013-07-27 14:33 ` Ramkumar Ramachandra
2013-07-27 15:17 ` Duy Nguyen [this message]
2013-07-27 16:05 ` Ramkumar Ramachandra
2013-07-27 23:25 ` Jiang Xin
2013-07-28 0:03 ` Ramkumar Ramachandra
2013-07-28 4:37 ` Duy Nguyen
2013-07-28 8:49 ` Ramkumar Ramachandra
2013-07-28 9:06 ` Duy Nguyen
2013-07-28 9:16 ` Ramkumar Ramachandra
2013-07-28 5:00 ` Duy Nguyen
2013-07-28 9:24 ` Ramkumar Ramachandra
2013-07-27 12:14 ` Fredrik Gustafsson
2013-07-27 13:26 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8CDg2ORKrpwiph=WdW5GPUYEwT1CSCttQ4fagQoMP4QGA@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).