git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Duy Nguyen <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Phillip Susi <psusi@ubuntu.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Clone from shallow bundle bug
Date: Thu, 2 Apr 2015 07:33:11 +0700	[thread overview]
Message-ID: <CACsJy8Cew0t9EZ5aVSCa-BehWz+ABRhDbtLR2cJ2K9c38QeGsA@mail.gmail.com> (raw)
In-Reply-To: <xmqqh9szn4t3.fsf@gitster.dls.corp.google.com>

On Thu, Apr 2, 2015 at 12:20 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Duy Nguyen <pclouds@gmail.com> writes:
>
>> Alternatively, we can record SHA-1 in the shallow file as refs whose
>> name is always ".shallow". This way "unbundle" can recreate the
>> shallow file if it wants.
>
> Wouldn't the extracting end care about such a name ".shallow" being
> duplicates (if you have multiple boundaries) or not check-ref-format
> kosher?

I think we are careful to ignore funny ref names, so it should not be
a problem. But I haven't tested this.

> I was hoping we will have a solution for a new bundle command to
> create a bundle out of a shallow repository that is somehow usable
> by existing 'git bundle' implementations.  You may take a bundle out
> of a shallow repository to preserve your work on top since you made
> the shallow clone originally, and then send it to your friend with
> existing 'git bundle' implementation to extract it into his full
> clone to sneaker-net.

OK two additional options on top of what we already have:

 - save .have and add extra prerequisite SHA-1.
 - create a bundle that does not hit shallow boundary in the first
place, roughly speaking it's "max depth minus one". This one does not
have extra .have or prerequisites
-- 
Duy

  reply	other threads:[~2015-04-02  0:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-31 21:10 Clone from shallow bundle bug Phillip Susi
2015-03-31 22:17 ` Junio C Hamano
2015-04-01  2:56   ` Phillip Susi
2015-04-01  6:31     ` Junio C Hamano
2015-04-01 10:01       ` Duy Nguyen
2015-04-01 13:00         ` Phillip Susi
2015-04-01 17:20         ` Junio C Hamano
2015-04-02  0:33           ` Duy Nguyen [this message]
2015-04-02  0:35             ` Duy Nguyen
2015-04-02  1:26             ` Phillip Susi
2015-04-01  9:55 ` Duy Nguyen
2015-04-01 12:53   ` Phillip Susi
2015-04-01 13:09     ` Duy Nguyen
2015-04-01 13:30       ` Phillip Susi
2015-04-01 13:36         ` Duy Nguyen
2015-04-01 14:06           ` Phillip Susi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACsJy8Cew0t9EZ5aVSCa-BehWz+ABRhDbtLR2cJ2K9c38QeGsA@mail.gmail.com \
    --to=pclouds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=psusi@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).