From: Duy Nguyen <pclouds@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [PATCH v1 10/19] read-cache: regenerate shared index if necessary
Date: Tue, 25 Oct 2016 17:16:04 +0700 [thread overview]
Message-ID: <CACsJy8CfQ6d3Q74W4rm=rJD69EAzuUe7PdrW-5NDo0vHuDSNpw@mail.gmail.com> (raw)
In-Reply-To: <20161023092648.12086-11-chriscool@tuxfamily.org>
On Sun, Oct 23, 2016 at 4:26 PM, Christian Couder
<christian.couder@gmail.com> wrote:
> @@ -2233,7 +2263,8 @@ int write_locked_index(struct index_state *istate, struct lock_file *lock,
> if ((v & 15) < 6)
> istate->cache_changed |= SPLIT_INDEX_ORDERED;
> }
> - if (istate->cache_changed & SPLIT_INDEX_ORDERED) {
> + if (istate->cache_changed & SPLIT_INDEX_ORDERED ||
> + too_many_not_shared_entries(istate)) {
It's probably safer to keep this piece unchanged and add this
somewhere before it
if (too_many_not_shared_entries(istate))
istate->cache_changed |= SPLIT_INDEX_ORDERED;
We could keep cache_changed consistent until the end this way.
> int ret = write_shared_index(istate, lock, flags);
> if (ret)
> return ret;
> diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh
> index db8c39f..507a1dd 100755
> --- a/t/t1700-split-index.sh
> +++ b/t/t1700-split-index.sh
> @@ -8,6 +8,7 @@ test_description='split index mode tests'
> sane_unset GIT_TEST_SPLIT_INDEX
>
> test_expect_success 'enable split index' '
> + git config splitIndex.maxPercentChange 100 &&
An alternative name might be splitThreshold. I don't know, maybe
maxPercentChange is better.
> git update-index --split-index &&
> test-dump-split-index .git/index >actual &&
> indexversion=$(test-index-version <.git/index) &&
> --
> 2.10.1.462.g7e1e03a
>
--
Duy
next prev parent reply other threads:[~2016-10-25 10:16 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 9:26 [PATCH v1 00/19] Add configuration options for split-index Christian Couder
2016-10-23 9:26 ` [PATCH v1 01/19] split-index: s/eith/with/ typo fix Christian Couder
2016-10-23 9:26 ` [PATCH v1 02/19] config: add git_config_get_split_index() Christian Couder
2016-10-23 9:26 ` [PATCH v1 03/19] split-index: add {add,remove}_split_index() functions Christian Couder
2016-10-25 9:58 ` Duy Nguyen
2016-10-29 22:06 ` Christian Couder
2016-11-07 10:08 ` Duy Nguyen
2016-11-09 9:24 ` Duy Nguyen
2016-11-09 14:47 ` Christian Couder
2016-10-23 9:26 ` [PATCH v1 04/19] read-cache: add and then use tweak_split_index() Christian Couder
2016-10-23 9:26 ` [PATCH v1 05/19] update-index: warn in case of split-index incoherency Christian Couder
2016-10-25 10:00 ` Duy Nguyen
2016-10-29 22:19 ` Christian Couder
2016-11-01 19:05 ` Junio C Hamano
2016-11-01 23:00 ` Christian Couder
2016-11-02 1:37 ` Junio C Hamano
2016-10-23 9:26 ` [PATCH v1 06/19] t1700: add tests for core.splitIndex Christian Couder
2016-10-23 9:26 ` [PATCH v1 07/19] Documentation/config: add information " Christian Couder
2016-10-23 9:26 ` [PATCH v1 08/19] Documentation/git-update-index: talk about core.splitIndex config var Christian Couder
2016-10-23 9:26 ` [PATCH v1 09/19] config: add git_config_get_max_percent_split_change() Christian Couder
2016-10-25 10:06 ` Duy Nguyen
2016-10-29 22:24 ` Christian Couder
2016-11-01 19:13 ` Junio C Hamano
2016-11-05 0:27 ` Christian Couder
2016-10-23 9:26 ` [PATCH v1 10/19] read-cache: regenerate shared index if necessary Christian Couder
2016-10-23 16:07 ` Ramsay Jones
2016-10-29 22:40 ` Christian Couder
2016-10-25 10:16 ` Duy Nguyen [this message]
2016-10-29 22:58 ` Christian Couder
2016-10-23 9:26 ` [PATCH v1 11/19] t1700: add tests for splitIndex.maxPercentChange Christian Couder
2016-11-01 19:15 ` Junio C Hamano
2016-10-23 9:26 ` [PATCH v1 12/19] Documentation/config: add splitIndex.maxPercentChange Christian Couder
2016-11-01 19:19 ` Junio C Hamano
2016-11-05 0:45 ` Christian Couder
2016-11-06 17:16 ` Junio C Hamano
[not found] ` <CAP8UFD1YL+RgdqbV0V1OnC=sJHJFc_an02Q9JeDNapW+u1CZcA@mail.gmail.com>
2016-11-07 9:38 ` Duy Nguyen
2016-11-18 14:34 ` Christian Couder
2016-11-22 10:35 ` Duy Nguyen
2016-11-22 13:13 ` Christian Couder
2016-11-22 13:20 ` Duy Nguyen
2016-10-23 9:26 ` [PATCH v1 13/19] sha1_file: make check_and_freshen_file() non static Christian Couder
2016-10-23 9:26 ` [PATCH v1 14/19] read-cache: touch shared index files when used Christian Couder
2016-10-25 10:26 ` Duy Nguyen
2016-11-01 19:23 ` Junio C Hamano
2016-10-23 9:26 ` [PATCH v1 15/19] config: add git_config_get_date_string() from gc.c Christian Couder
2016-11-01 19:28 ` Junio C Hamano
2016-11-23 15:04 ` Christian Couder
2016-11-23 17:34 ` Junio C Hamano
2016-11-28 16:19 ` Christian Couder
2016-11-28 16:56 ` Junio C Hamano
2016-10-23 9:26 ` [PATCH v1 16/19] read-cache: unlink old sharedindex files Christian Couder
2016-10-25 10:43 ` Duy Nguyen
2016-10-27 10:25 ` Duy Nguyen
2016-10-27 12:14 ` Christian Couder
2016-10-27 16:13 ` Junio C Hamano
2016-10-29 3:30 ` Duy Nguyen
2016-10-23 9:26 ` [PATCH v1 17/19] t1700: test shared index file expiration Christian Couder
2016-10-23 9:26 ` [PATCH v1 18/19] Documentation/config: add splitIndex.sharedIndexExpire Christian Couder
2016-10-23 9:26 ` [PATCH v1 19/19] Documentation/git-update-index: explain splitIndex.* Christian Couder
2016-10-24 18:07 ` [PATCH v1 00/19] Add configuration options for split-index Junio C Hamano
2016-10-25 9:30 ` Duy Nguyen
2016-10-25 17:21 ` Junio C Hamano
2016-10-26 9:25 ` Duy Nguyen
2016-10-26 16:14 ` Junio C Hamano
2016-10-25 10:52 ` Duy Nguyen
2016-11-03 14:34 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8CfQ6d3Q74W4rm=rJD69EAzuUe7PdrW-5NDo0vHuDSNpw@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).