From: Duy Nguyen <pclouds@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
John Keeping <john@keeping.me.uk>
Subject: Re: [PATCH v2] git config: report when trying to modify a non-existing repo config
Date: Wed, 24 Feb 2016 20:29:59 +0700 [thread overview]
Message-ID: <CACsJy8CuLPCYAtNn4u-RYHhL=LqGJH_GFNwbAWHxfdAximLtug@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1602241425180.3152@virtualbox>
On Wed, Feb 24, 2016 at 8:26 PM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> Hi Duy,
>
> On Wed, 24 Feb 2016, Duy Nguyen wrote:
>
>> On Wed, Feb 24, 2016 at 01:48:11PM +0100, Johannes Schindelin wrote:
>> > + die("not in a git directory");
>>
>> Maybe wrap this string with _() for translation? Then we can pile this
>> patch on top to fix the rest in builtin/config.c.
>
> Given that the context lines contain die() calls *without* _(), I would
> find it more logical if your patch patched also the line I introduced,
> together with the other die() calls.
No problem. I'll go over all changes in 'next' and 'pu' some time
later and try to fix them all.
--
Duy
next prev parent reply other threads:[~2016-02-24 13:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 7:47 [PATCH] git config: do not create .git/ if it does not exist yet Johannes Schindelin
2016-02-24 8:26 ` Jeff King
2016-02-24 10:14 ` John Keeping
2016-02-24 10:31 ` Jeff King
2016-02-24 11:31 ` Johannes Schindelin
2016-02-24 12:13 ` Johannes Schindelin
2016-02-24 12:34 ` Jeff King
2016-02-24 18:45 ` Junio C Hamano
2016-02-24 11:01 ` Duy Nguyen
2016-02-24 12:48 ` [PATCH v2] git config: report when trying to modify a non-existing repo config Johannes Schindelin
2016-02-24 12:59 ` Duy Nguyen
2016-02-24 13:26 ` Johannes Schindelin
2016-02-24 13:29 ` Duy Nguyen [this message]
2016-02-24 20:11 ` Junio C Hamano
2016-02-24 22:31 ` Junio C Hamano
2016-02-25 15:54 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8CuLPCYAtNn4u-RYHhL=LqGJH_GFNwbAWHxfdAximLtug@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).