* About *git clone --depth=n* puzzle
@ 2013-08-14 8:20 XinLingchao
2013-08-14 8:51 ` Stefan Beller
2013-08-15 2:08 ` Duy Nguyen
0 siblings, 2 replies; 6+ messages in thread
From: XinLingchao @ 2013-08-14 8:20 UTC (permalink / raw)
To: git@vger.kernel.org; +Cc: junchunx.guan@gmail.com
Hi Guys,
I think I have got some trouble when I use `git clone --depth=n` command. Take a real repo for example:
`git clone https://github.com/douglarek/vimrc.git --depth=1`
then I use `git log`:
```
commit d04ca09ecc723739123fae11ad56784eb0c9b36a
Author: Lingchao Xin <douglarek@outlook.com>
Date: Fri Jun 7 09:39:22 2013 +0800
Update vnudle to master branch, add wm shortcut, pylint optimization
commit c66d827dc212f6ae8aab6b5c44631564bcbe2acd
Author: icocoa <lingchax@outlook.com>
Date: Tue Mar 12 01:36:34 2013 -0700
Merge pull request #1 from douglarek/master
Add markdown, flake8, pylint plugin
```
but when I clone it with `file://`:
git clone https://github.com/douglarek/vimrc.git
git clone file://vimrc.git --depth=1 vimrc1
I got this log:
```
commit d04ca09ecc723739123fae11ad56784eb0c9b36a
Author: Lingchao Xin <douglarek@outlook.com>
Date: Fri Jun 7 09:39:22 2013 +0800
Update vnudle to master branch, add wm shortcut, pylint optimization
```
so the two results are not same, is it a bug? or it should be so?
My os is openSUSE 12.3 and git version 1.8.3.4; and myabe it occured in git 1.8.1.4 +.
Thanks and Best regards
Lingchao Xin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: About *git clone --depth=n* puzzle
2013-08-14 8:20 About *git clone --depth=n* puzzle XinLingchao
@ 2013-08-14 8:51 ` Stefan Beller
2013-08-14 9:19 ` XinLingchao
2013-08-15 2:08 ` Duy Nguyen
1 sibling, 1 reply; 6+ messages in thread
From: Stefan Beller @ 2013-08-14 8:51 UTC (permalink / raw)
To: XinLingchao; +Cc: git@vger.kernel.org, junchunx.guan@gmail.com
[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]
On 08/14/2013 10:20 AM, XinLingchao wrote:
> Hi Guys,
>
> I think I have got some trouble when I use `git clone --depth=n` command. Take a real repo for example:
>
>
> `git clone https://github.com/douglarek/vimrc.git --depth=1`
>
>
> then I use `git log`:
>
> ```
> commit d04ca09ecc723739123fae11ad56784eb0c9b36a
> Author: Lingchao Xin <douglarek@outlook.com>
> Date: Fri Jun 7 09:39:22 2013 +0800
>
> Update vnudle to master branch, add wm shortcut, pylint optimization
>
> commit c66d827dc212f6ae8aab6b5c44631564bcbe2acd
> Author: icocoa <lingchax@outlook.com>
> Date: Tue Mar 12 01:36:34 2013 -0700
>
> Merge pull request #1 from douglarek/master
>
> Add markdown, flake8, pylint plugin
>
> ```
> but when I clone it with `file://`:
>
> git clone https://github.com/douglarek/vimrc.git
> git clone file://vimrc.git --depth=1 vimrc1
>
> I got this log:
> ```
> commit d04ca09ecc723739123fae11ad56784eb0c9b36a
> Author: Lingchao Xin <douglarek@outlook.com>
> Date: Fri Jun 7 09:39:22 2013 +0800
>
> Update vnudle to master branch, add wm shortcut, pylint optimization
> ```
>
> so the two results are not same, is it a bug? or it should be so?
>
> My os is openSUSE 12.3 and git version 1.8.3.4; and myabe it occured in git 1.8.1.4 +.
>
>
> Thanks and Best regards
>
> Lingchao Xin --
There was a similar discussion going on in July this year,
maybe this is an interesting read with respect to this topic
http://www.spinics.net/lists/git/msg196138.html
Stefan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: About *git clone --depth=n* puzzle
2013-08-14 8:51 ` Stefan Beller
@ 2013-08-14 9:19 ` XinLingchao
2013-08-14 11:59 ` Jeff King
0 siblings, 1 reply; 6+ messages in thread
From: XinLingchao @ 2013-08-14 9:19 UTC (permalink / raw)
To: Stefan Beller; +Cc: git@vger.kernel.org, junchunx.guan@gmail.com
---------------------------------------
> Date: Wed, 14 Aug 2013 10:51:53 +0200
> From: stefanbeller@googlemail.com
> To: douglarek@outlook.com
> CC: git@vger.kernel.org; junchunx.guan@gmail.com
> Subject: Re: About *git clone --depth=n* puzzle
>
> On 08/14/2013 10:20 AM, XinLingchao wrote:
>> Hi Guys,
>>
>> I think I have got some trouble when I use `git clone --depth=n` command. Take a real repo for example:
>>
>>
>> `git clone https://github.com/douglarek/vimrc.git --depth=1`
>>
>>
>> then I use `git log`:
>>
>> ```
>> commit d04ca09ecc723739123fae11ad56784eb0c9b36a
>> Author: Lingchao Xin <douglarek@outlook.com>
>> Date: Fri Jun 7 09:39:22 2013 +0800
>>
>> Update vnudle to master branch, add wm shortcut, pylint optimization
>>
>> commit c66d827dc212f6ae8aab6b5c44631564bcbe2acd
>> Author: icocoa <lingchax@outlook.com>
>> Date: Tue Mar 12 01:36:34 2013 -0700
>>
>> Merge pull request #1 from douglarek/master
>>
>> Add markdown, flake8, pylint plugin
>>
>> ```
>> but when I clone it with `file://`:
>>
>> git clone https://github.com/douglarek/vimrc.git
>> git clone file://vimrc.git --depth=1 vimrc1
>>
>> I got this log:
>> ```
>> commit d04ca09ecc723739123fae11ad56784eb0c9b36a
>> Author: Lingchao Xin <douglarek@outlook.com>
>> Date: Fri Jun 7 09:39:22 2013 +0800
>>
>> Update vnudle to master branch, add wm shortcut, pylint optimization
>> ```
>>
>> so the two results are not same, is it a bug? or it should be so?
>>
>> My os is openSUSE 12.3 and git version 1.8.3.4; and myabe it occured in git 1.8.1.4 +.
>>
>>
>> Thanks and Best regards
>>
>> Lingchao Xin --
>
> There was a similar discussion going on in July this year,
> maybe this is an interesting read with respect to this topic
> http://www.spinics.net/lists/git/msg196138.html
>
> Stefan
>
>
Stefan, I do NOT think so, the key point is not about the depth limit, it is about whether remote clone depth equals local clone depth.
cheers
Lingchao Xin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: About *git clone --depth=n* puzzle
2013-08-14 9:19 ` XinLingchao
@ 2013-08-14 11:59 ` Jeff King
2013-08-14 12:45 ` XinLingchao
0 siblings, 1 reply; 6+ messages in thread
From: Jeff King @ 2013-08-14 11:59 UTC (permalink / raw)
To: XinLingchao; +Cc: Stefan Beller, git@vger.kernel.org, junchunx.guan@gmail.com
On Wed, Aug 14, 2013 at 05:19:36PM +0800, XinLingchao wrote:
> > There was a similar discussion going on in July this year,
> > maybe this is an interesting read with respect to this topic
> > http://www.spinics.net/lists/git/msg196138.html
> >
> Stefan, I do NOT think so, the key point is not about the depth limit,
> it is about whether remote clone depth equals local clone depth.
I do not think it is about local vs remote, but rather about which
version of git the remote side is running. Prior to 682c7d2
(upload-pack: fix off-by-one depth calculation in shallow clone,
2013-01-11), a shallow clone always returned one extra commit. That fix
went into v1.8.2.
So if you have a post-v1.8.2 git client, a local clone will use the same
git version as the "remote" side of the connection. But if you are
contacting a remote server, the results you get will depend on what
version of git is running on the remote server.
And as the example you showed uses github.com as the remote, and as I
happen to know that GitHub's servers do not currently have 682c7d2, you
would see the old behavior.
-Peff
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: About *git clone --depth=n* puzzle
2013-08-14 11:59 ` Jeff King
@ 2013-08-14 12:45 ` XinLingchao
0 siblings, 0 replies; 6+ messages in thread
From: XinLingchao @ 2013-08-14 12:45 UTC (permalink / raw)
To: Jeff King; +Cc: Stefan Beller, git@vger.kernel.org, junchunx.guan@gmail.com
Peff, thanks for your detial explain, and I think I have got the point :P
-Lingchao Xin
----------------------------------------
> Date: Wed, 14 Aug 2013 07:59:56 -0400
> From: peff@peff.net
> To: douglarek@outlook.com
> CC: stefanbeller@googlemail.com; git@vger.kernel.org; junchunx.guan@gmail.com
> Subject: Re: About *git clone --depth=n* puzzle
>
> On Wed, Aug 14, 2013 at 05:19:36PM +0800, XinLingchao wrote:
>
>>> There was a similar discussion going on in July this year,
>>> maybe this is an interesting read with respect to this topic
>>> http://www.spinics.net/lists/git/msg196138.html
>>>
>> Stefan, I do NOT think so, the key point is not about the depth limit,
>> it is about whether remote clone depth equals local clone depth.
>
> I do not think it is about local vs remote, but rather about which
> version of git the remote side is running. Prior to 682c7d2
> (upload-pack: fix off-by-one depth calculation in shallow clone,
> 2013-01-11), a shallow clone always returned one extra commit. That fix
> went into v1.8.2.
>
> So if you have a post-v1.8.2 git client, a local clone will use the same
> git version as the "remote" side of the connection. But if you are
> contacting a remote server, the results you get will depend on what
> version of git is running on the remote server.
>
> And as the example you showed uses github.com as the remote, and as I
> happen to know that GitHub's servers do not currently have 682c7d2, you
> would see the old behavior.
>
> -Peff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: About *git clone --depth=n* puzzle
2013-08-14 8:20 About *git clone --depth=n* puzzle XinLingchao
2013-08-14 8:51 ` Stefan Beller
@ 2013-08-15 2:08 ` Duy Nguyen
1 sibling, 0 replies; 6+ messages in thread
From: Duy Nguyen @ 2013-08-15 2:08 UTC (permalink / raw)
To: XinLingchao; +Cc: git@vger.kernel.org, junchunx.guan@gmail.com
On Wed, Aug 14, 2013 at 3:20 PM, XinLingchao <douglarek@outlook.com> wrote:
> Hi Guys,
>
> I think I have got some trouble when I use `git clone --depth=n` command. Take a real repo for example:
>
>
> `git clone https://github.com/douglarek/vimrc.git --depth=1`
>
>
> then I use `git log`:
>
> ```
> commit d04ca09ecc723739123fae11ad56784eb0c9b36a
> Author: Lingchao Xin <douglarek@outlook.com>
> Date: Fri Jun 7 09:39:22 2013 +0800
>
> Update vnudle to master branch, add wm shortcut, pylint optimization
>
> commit c66d827dc212f6ae8aab6b5c44631564bcbe2acd
> Author: icocoa <lingchax@outlook.com>
> Date: Tue Mar 12 01:36:34 2013 -0700
>
> Merge pull request #1 from douglarek/master
>
> Add markdown, flake8, pylint plugin
>
> ```
> but when I clone it with `file://`:
>
> git clone https://github.com/douglarek/vimrc.git
> git clone file://vimrc.git --depth=1 vimrc1
>
> I got this log:
> ```
> commit d04ca09ecc723739123fae11ad56784eb0c9b36a
> Author: Lingchao Xin <douglarek@outlook.com>
> Date: Fri Jun 7 09:39:22 2013 +0800
>
> Update vnudle to master branch, add wm shortcut, pylint optimization
> ```
>
> so the two results are not same, is it a bug? or it should be so?
>
> My os is openSUSE 12.3 and git version 1.8.3.4; and myabe it occured in git 1.8.1.4 +.
The fix is at the server side. >=1.8.2 corrects --depth, which is what
you use for file://. github is still on 1.8.1.6, which does not have
that fix. Oh and the commit is 682c7d2 (upload-pack: fix off-by-one
depth calculation in shallow clone - 2013-01-11)
--
Duy
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-15 2:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-14 8:20 About *git clone --depth=n* puzzle XinLingchao
2013-08-14 8:51 ` Stefan Beller
2013-08-14 9:19 ` XinLingchao
2013-08-14 11:59 ` Jeff King
2013-08-14 12:45 ` XinLingchao
2013-08-15 2:08 ` Duy Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).