From: Duy Nguyen <pclouds@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] add: add --bulk to index all objects into a pack file
Date: Fri, 4 Oct 2013 14:19:45 +0700 [thread overview]
Message-ID: <CACsJy8DOziJ9z2p-2BttJf=zZUC6GsRVtKru3R6Kn32-B0tAdA@mail.gmail.com> (raw)
In-Reply-To: <vpqfvshecjg.fsf@anie.imag.fr>
On Fri, Oct 4, 2013 at 2:10 PM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>> except that it does not deltifies nor sort objects.
>
> I think this should be mentionned in the doc. Otherwise, it seems like
> "git add --bulk" is like "git add && git repack".
Yep. Will do.
> BTW, will the next "git gc" be efficient after a "add --bulk"? I mean:
> will it consider the pack as "already pack" and let it as-is, without
> deltification, or will it get a chance to actually repack efficiently?
gc does "repack -A" so all separate packs will be merged. It may delay
gc time though because it'll take more time to hit the loose object
limit. I think pack-objects will try to deltify so we're good. If we
produce bad deltas in --bulk then that's another story because
pack-objects will try to blindly reuse them.
--
Duy
next prev parent reply other threads:[~2013-10-04 7:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 4:00 [PATCH] add: add --bulk to index all objects into a pack file Nguyễn Thái Ngọc Duy
2013-10-03 6:43 ` Junio C Hamano
2013-10-03 12:26 ` Duy Nguyen
2013-10-04 6:57 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2013-10-04 7:10 ` Matthieu Moy
2013-10-04 7:19 ` Duy Nguyen [this message]
2013-10-04 12:38 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8DOziJ9z2p-2BttJf=zZUC6GsRVtKru3R6Kn32-B0tAdA@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).