From: Duy Nguyen <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Brandon Richardson <brandon1024.br@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Andrei Rybak <rybak.a.v@gmail.com>, Jeff King <peff@peff.net>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v4] commit-tree: utilize parse-options api
Date: Thu, 7 Mar 2019 14:47:34 +0700 [thread overview]
Message-ID: <CACsJy8DUGxUOko5fk5LLWKo_pmxAF=4NJxobNvGqWjTFWFNFiA@mail.gmail.com> (raw)
In-Reply-To: <xmqqy35rpp13.fsf@gitster-ct.c.googlers.com>
On Thu, Mar 7, 2019 at 6:21 AM Junio C Hamano <gitster@pobox.com> wrote:
> The change to this main function looks quite straight-forward. I am
> kind of surprised that a very low hanging fruit like this had survived
> without getting hit by parseopt a lot earlier ;-)
There are more (I guess we tag #leftovers nowadays?)
git grep 'strcmp.*\"--[a-z]' builtin/
(with some false positives)
--
Duy
prev parent reply other threads:[~2019-03-07 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 15:49 [PATCH v4] commit-tree: utilize parse-options api Brandon Richardson
2019-03-06 23:21 ` Junio C Hamano
2019-03-07 1:52 ` Brandon Richardson
2019-03-07 7:47 ` Duy Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8DUGxUOko5fk5LLWKo_pmxAF=4NJxobNvGqWjTFWFNFiA@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=brandon1024.br@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=rybak.a.v@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).