From: Lucian Poston <lucian.poston@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>
Subject: Re: [PATCH v3 4/7] t4052: Adjust --graph --stat output for prefixes
Date: Tue, 17 Apr 2012 19:23:49 -0700 [thread overview]
Message-ID: <CACz_eyfvC9OWwBscCTHVvs+udRW5_QUReZnxpPVWSrL1MAC6rA@mail.gmail.com> (raw)
In-Reply-To: <7vzkabtsw9.fsf@alter.siamese.dyndns.org>
On Mon, Apr 16, 2012 at 11:48, Junio C Hamano <gitster@pobox.com> wrote:
>> @@ -117,7 +117,7 @@ cat >expect40 <<'EOF'
>> abcd | 1000 ++++++++++++++++++++++++++
>> EOF
>> cat >expect40-graph <<'EOF'
>> -| abcd | 1000 ++++++++++++++++++++++++++
>> +| abcd | 1000 ++++++++++++++++++++++++
>> EOF
>> while read verb expect cmd args
>> do
>> @@ -127,12 +127,6 @@ do
>> test_cmp "$expect" actual
>> '
>>
>> - test_expect_success "$cmd $verb statGraphWidth config" '
>> - git -c diff.statGraphWidth=26 $cmd $args >output
>> - grep " | " output >actual &&
>> - test_cmp "$expect" actual
>> - '
>> -
>
> This is unclear. Why does this need to be removed?
This test was actually only moved. There were 4 test_expect_success in
a while loop -- 2 tested COLUMNS=40, and 2 tested
diff.statGraphWidth=26. I moved the two tests for diff.statGraphWidth
to a new while loop. expect40-graph varies between these two sets of
tests, so I thought it cleaner to separate them so that the
expectation could be defined separately.
next prev parent reply other threads:[~2012-04-18 2:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 10:44 [PATCH v3 0/7] diff stat calculation adjustments Lucian Poston
2012-04-16 10:44 ` [PATCH v3 1/7] t4052: test --stat output with --graph Lucian Poston
2012-04-16 10:44 ` [PATCH v3 2/7] Add output_prefix_length to diff_options Lucian Poston
2012-04-16 18:48 ` Junio C Hamano
2012-04-18 2:31 ` Lucian Poston
2012-04-16 10:44 ` [PATCH v3 3/7] Adjust stat width calculations to take --graph output into account Lucian Poston
2012-04-16 10:44 ` [PATCH v3 4/7] t4052: Adjust --graph --stat output for prefixes Lucian Poston
2012-04-16 18:48 ` Junio C Hamano
2012-04-18 2:23 ` Lucian Poston [this message]
2012-04-16 10:44 ` [PATCH v3 5/7] t4052: Add tests to illustrate issues with restrictive COLUMNS Lucian Poston
2012-04-16 18:48 ` Junio C Hamano
2012-04-18 2:31 ` Lucian Poston
2012-04-16 10:44 ` [PATCH v3 6/7] Prevent graph_width of diff stat from falling below min Lucian Poston
2012-04-16 10:44 ` [PATCH v3 7/7] t4052: Adjust --stat output for minimum graph_width Lucian Poston
2012-04-16 19:30 ` [PATCH v3 0/7] diff stat calculation adjustments Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACz_eyfvC9OWwBscCTHVvs+udRW5_QUReZnxpPVWSrL1MAC6rA@mail.gmail.com \
--to=lucian.poston@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).