From: J Smith <dark.panda@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC] grep: add a perlRegexp configuration option
Date: Tue, 31 Jul 2012 16:35:44 -0400 [thread overview]
Message-ID: <CADFUPgfrG75FkSNV6JS22DAciD3CVkNEjKncNJOPkfRQSf41Pg@mail.gmail.com> (raw)
In-Reply-To: <7vboivishe.fsf@alter.siamese.dyndns.org>
On Tue, Jul 31, 2012 at 4:30 PM, Junio C Hamano <gitster@pobox.com> wrote:
> J Smith <dark.panda@gmail.com> writes:
>
>> ... For the sake of completeness (verbosity? pedantry?) I also
>> included a setting for "extended" which is equivalent to true.
>
> Good thinking.
>
>> With this sort of change, would a more generic "grep.regexpMode",
>> "grep.patternType" or something similar perhaps be more descriptive,
>> with "grep.extendedRegexp" being aliased for backwards compatibility
>> purposes? I could also add that functionality if desired.
>
> A variable called "extendedRegexp" already reads quite naturally if
> it can have value to say what kind of extendedness is desired, at
> least to me. So I do not care too deeply either way.
On the flip side, it might be useful to some to have the option to set
the value to "fixed" for the "--fixed-strings" argument, in which case
the option becomes less a type of extended regexp and more of a simple
search string. Were that to be the case, I think "grep.patternType"
would feel the most precise.
I think for completeness at the very least I should work in the
"fixed" value as an valid value, option naming aside.
next prev parent reply other threads:[~2012-07-31 20:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 16:57 [PATCH/RFC] grep: add a perlRegexp configuration option J Smith
2012-07-31 18:04 ` Junio C Hamano
2012-07-31 20:20 ` J Smith
2012-07-31 20:30 ` Junio C Hamano
2012-07-31 20:35 ` J Smith [this message]
2012-07-31 21:05 ` Junio C Hamano
2012-07-31 22:56 ` J Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADFUPgfrG75FkSNV6JS22DAciD3CVkNEjKncNJOPkfRQSf41Pg@mail.gmail.com \
--to=dark.panda@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).