From: Luke Diamand <luke@diamand.org>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Git List" <git@vger.kernel.org>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Merland Romain" <merlorom@yahoo.fr>,
"Miguel Torroja" <miguel.torroja@gmail.com>,
"vin ku" <viniciusalexandre@gmail.com>,
"Lars Schneider" <larsxschneider@gmail.com>,
"Lex Spoon" <lex@lexspoon.org>
Subject: Re: [PATCHv1 1/3] git-p4: raise exceptions from p4CmdList based on error from p4 server
Date: Fri, 8 Jun 2018 11:06:56 +0100 [thread overview]
Message-ID: <CAE5ih7-4CTOgaWuc2dVha5bcF1MsD+ERPj3hQNTOddOrkvMZWw@mail.gmail.com> (raw)
In-Reply-To: <CAE5ih7-HMRJ3nFNuQCXmJEC4Ar4PZY=_4Q=4gDK+VTFRhMvCGA@mail.gmail.com>
>>
>>> ErrorId MsgDb::MaxResults = { ErrorOf( ES_DB, 32,
>>> E_FAILED, EV_ADMIN, 1 ), "Request too large (over %maxResults%); see
>>> 'p4 help maxresults'." } ;//NOTRANS
>>> ErrorId MsgDb::MaxScanRows = { ErrorOf( ES_DB, 61,
>>> E_FAILED, EV_ADMIN, 1 ), "Too many rows scanned (over %maxScanRows%);
>>> see 'p4 help maxscanrows'." } ;//NOTRANS
>>>
>>> I don't think there's actually a way to make it return any language
>>> other than English though. [...]
>>> So I think probably the language is always English.
>>
>> The "NOTRANS" annotation on the error messages is reassuring.
>
> I'll check it works OK on Windows; charset translation might cause a problem.
Works OK on Windows with 2017.2 client/server.
next prev parent reply other threads:[~2018-06-08 10:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 9:13 [PATCHv1 0/3] git-p4: improvements to p4 "blocking" Luke Diamand
2018-06-05 9:13 ` [PATCHv1 1/3] git-p4: raise exceptions from p4CmdList based on error from p4 server Luke Diamand
2018-06-05 9:54 ` Eric Sunshine
2018-06-05 10:56 ` Luke Diamand
2018-06-05 19:41 ` Eric Sunshine
2018-06-05 22:14 ` Luke Diamand
2018-06-08 10:06 ` Luke Diamand [this message]
2018-06-05 9:13 ` [PATCHv1 2/3] git-p4: narrow the scope of exceptions caught when parsing an int Luke Diamand
2018-06-05 9:13 ` [PATCHv1 3/3] git-p4: auto-size the block Luke Diamand
2018-06-05 10:05 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE5ih7-4CTOgaWuc2dVha5bcF1MsD+ERPj3hQNTOddOrkvMZWw@mail.gmail.com \
--to=luke@diamand.org \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=lex@lexspoon.org \
--cc=merlorom@yahoo.fr \
--cc=miguel.torroja@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=szeder.dev@gmail.com \
--cc=viniciusalexandre@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).