From: Luke Diamand <luke@diamand.org>
To: Stefan Beller <sbeller@google.com>
Cc: Jacob Smith <jaroslov@gmail.com>,
Lars Schneider <larsxschneider@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: BUG on OSX `git p4 submit` can fail when the workspace root doesn't exist locally.
Date: Thu, 28 Apr 2016 08:36:33 +0100 [thread overview]
Message-ID: <CAE5ih78eGJN2kUjxfhUiKTAMK5rbTGZ-SFp405w2XRL6BDvwHQ@mail.gmail.com> (raw)
In-Reply-To: <CAGZ79kZX5H8ddhZQa4r9SPyhAYo=o6gBae3oPCYQ6iNtxXq1Cg@mail.gmail.com>
On 27 April 2016 at 21:53, Stefan Beller <sbeller@google.com> wrote:
> On Wed, Apr 27, 2016 at 11:06 AM, Jacob Smith <jaroslov@gmail.com> wrote:
>> I debugged the issue using the script here:
>> https://github.com/git/git/blob/master/git-p4.py
>> I'm not sure how close to the main repo that is.
>>
>> On Wed, Apr 27, 2016 at 11:28 AM, Stefan Beller <sbeller@google.com> wrote:
>>> On Wed, Apr 27, 2016 at 9:15 AM, Jacob Smith <jaroslov@gmail.com> wrote:
>>>> On OS X,
>>>
>>> Do you use the Git as provided from OS X? In that case you better report the bug
>>> to Apple, as their version of Git is slightly different (not close on
>>> upstream, by both
>>> having additional patches as well as not following the upstream closely IIUC).
>
> In that case, I have cc'd Luke and Lars, who work on p4
Which version of p4 are you using?
Your suggested fix looks plausible though. Possibly it needs both
chdirs() so that "p4 sync" will work if the caller is using a
.p4config file in the p4 client directory to set the P4CLIENT.
Thanks!
Luke
prev parent reply other threads:[~2016-04-28 7:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 16:15 BUG on OSX `git p4 submit` can fail when the workspace root doesn't exist locally Jacob Smith
2016-04-27 16:28 ` Stefan Beller
2016-04-27 18:06 ` Jacob Smith
2016-04-27 20:53 ` Stefan Beller
2016-04-28 7:36 ` Luke Diamand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE5ih78eGJN2kUjxfhUiKTAMK5rbTGZ-SFp405w2XRL6BDvwHQ@mail.gmail.com \
--to=luke@diamand.org \
--cc=git@vger.kernel.org \
--cc=jaroslov@gmail.com \
--cc=larsxschneider@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).