git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luke Diamand <luke@diamand.org>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
	"Git Users" <git@vger.kernel.org>, "Pete Wyckoff" <pw@padd.com>,
	"Tor Arvid Lund" <torarvid@gmail.com>,
	ksaitoh560@gmail.com, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v5] git-p4: Obey core.ignorecase when using P4 client specs.
Date: Wed, 26 Aug 2015 11:18:37 +0100	[thread overview]
Message-ID: <CAE5ih791vqnyk_J8Sq9LXq+WZW31OwEuCiD6-wwVLo-tXxHOMA@mail.gmail.com> (raw)
In-Reply-To: <55DCB2E0.5090605@diamand.org>

On 25 August 2015 at 19:24, Luke Diamand <luke@diamand.org> wrote:
> On 25/08/15 14:14, Lars Schneider wrote:
>>>
>>>
>>> So the choices are:
>>>
>>> 1. A new command-line option which would silently set core.ignorecase
>>> 2. Users just have to know to set core.ignorecase manually before
>>> using git-p4 (i.e. Lars' patch v5)
>>> 3. Fix fast-import to take a --casefold option (but that's a much bigger
>>> change)
>>>
>> I vote for 2 because that solves the problem consistently with the
>> existing implementation for now. That means we don’t surprise git-p4 users.
>> In addition I would try to fix (3), the —casefold option, in a separate
>> patch. Although this (3) patch could take a bit as I have two more git-p4
>> patches in the queue that I want to propose to the mailing list first.
>
>
> That works for me. Ack.
>
> Thanks!
> Luke

Lars - could you resubmit PATCHv5 as v6, with Acked-by from me added
after the Signed-off-by: line.
It then this from SubmittingPatches:

> After the list reached a consensus that it is a good idea to apply the
> patch, re-send it with "To:" set to the maintainer [*1*] and "cc:" the
> list [*2*] for inclusion.

Thanks
Luke

      reply	other threads:[~2015-08-26 10:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24 21:30 [PATCH v5] git-p4: Obey core.ignorecase when using P4 client specs larsxschneider
2015-08-24 21:30 ` larsxschneider
2015-08-25  6:54 ` Luke Diamand
2015-08-25  8:17   ` Lars Schneider
2015-08-25  8:33   ` Torsten Bögershausen
2015-08-25 10:30     ` Lars Schneider
2015-08-25 11:57       ` Luke Diamand
2015-08-25 13:14         ` Lars Schneider
2015-08-25 18:24           ` Luke Diamand
2015-08-26 10:18             ` Luke Diamand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAE5ih791vqnyk_J8Sq9LXq+WZW31OwEuCiD6-wwVLo-tXxHOMA@mail.gmail.com \
    --to=luke@diamand.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ksaitoh560@gmail.com \
    --cc=larsxschneider@gmail.com \
    --cc=pw@padd.com \
    --cc=tboegi@web.de \
    --cc=torarvid@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).