From: Max Kirillov <max@max630.net>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] t5562: avoid non-portable "export FOO=bar" construct
Date: Mon, 30 Jul 2018 06:55:12 +0300 [thread overview]
Message-ID: <CAF7_NFRNcHh2d91s5Sd1QiC-b+9dshjiHH2O-jCfS1gw7fTp+A@mail.gmail.com> (raw)
In-Reply-To: <c5b2a072-5058-0d3e-8fb0-52b84bfcdfa9@ramsayjones.plus.com>
> Commit 6c213e863a ("http-backend: respect CONTENT_LENGTH for
receive-pack", 2018-07-27) adds a test which uses the non-portable
export construct. Replace it with "FOO=bar && export FOO" instead.
Thank you. Apparently the check is performed by make -C t, and I did
not run it like this since I only changed the test.
prev parent reply other threads:[~2018-07-30 3:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-28 22:51 [PATCH] t5562: avoid non-portable "export FOO=bar" construct Ramsay Jones
2018-07-29 3:13 ` Eric Sunshine
2018-07-29 15:32 ` Ramsay Jones
2018-07-30 3:55 ` Max Kirillov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF7_NFRNcHh2d91s5Sd1QiC-b+9dshjiHH2O-jCfS1gw7fTp+A@mail.gmail.com \
--to=max@max630.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).