From: Loganaden Velvindron <logan@hackers.mu>
To: Daniel Stenberg <daniel@haxx.se>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] Allow use of TLS 1.3
Date: Sat, 24 Mar 2018 08:31:47 +0400 [thread overview]
Message-ID: <CAFDEUTd_t554b=7xWcO=bY21YTRfbz8SwLVjEmdbCRb=56v6FA@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1803232246020.16250@tvnag.unkk.fr>
On Sat, Mar 24, 2018 at 1:47 AM, Daniel Stenberg <daniel@haxx.se> wrote:
> On Fri, 23 Mar 2018, Loganaden Velvindron wrote:
>
>> +#ifdef CURL_SSLVERSION_TLSv1_3
>> + { "tlsv1.3", CURL_SSLVERSION_TLSv1_3 }
>> +#endif
>
>
> Unfortunately, CURL_SSLVERSION_TLSv1_3 is an enum so this construct won't
> work.
>
> Also, let me just point out that 7.52.0 is 0x073400 in hex and not the one
> used for the first version of this patch.
>
Yeah, v1 patch is broken. I'm sending a v3 patch which is properly
tested with OpenSSL preview alpha.
> --
>
> / daniel.haxx.se
next prev parent reply other threads:[~2018-03-24 4:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 19:34 [PATCH v2] Allow use of TLS 1.3 Loganaden Velvindron
2018-03-23 21:47 ` Daniel Stenberg
2018-03-23 22:04 ` Junio C Hamano
2018-03-24 7:52 ` Loganaden Velvindron
2018-03-24 4:21 ` Loganaden Velvindron
2018-03-24 4:31 ` Loganaden Velvindron [this message]
2018-03-24 5:43 ` Loganaden Velvindron
2018-03-23 21:55 ` Junio C Hamano
2018-03-23 22:28 ` Ævar Arnfjörð Bjarmason
2018-03-24 4:23 ` Loganaden Velvindron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFDEUTd_t554b=7xWcO=bY21YTRfbz8SwLVjEmdbCRb=56v6FA@mail.gmail.com' \
--to=logan@hackers.mu \
--cc=daniel@haxx.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).