git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Packham <judge.packham@gmail.com>
To: paulus@samba.org
Cc: GIT <git@vger.kernel.org>
Subject: Re: gitk bug: write commit to file takes commit message from previous commit
Date: Wed, 3 Sep 2014 17:47:39 +1200	[thread overview]
Message-ID: <CAFOYHZDtaLEcdOSGA8h99rDTUzsn9z7JytgFLi-WGzZ525QkvQ@mail.gmail.com> (raw)
In-Reply-To: <CAFOYHZAWnaQNcCDbS3-2zxacYaD=egwhCT7qAc1DorRZ3_Pe_Q@mail.gmail.com>

On Wed, Sep 3, 2014 at 5:22 PM, Chris Packham <judge.packham@gmail.com> wrote:
> Hi Paul,
>
> Just noticed something in the version of gitk included in git 2.0.3.
>
> When I right click on a commit and select "write commit to file" the
> resulting file has the diff from the selected commit but the commit
> message from the previous commit.
>
> Attached is an example from running gitk on gitk
> (git://ozlabs.org/~paulus/gitk). As you can see the author, sha1 and
> diff are from 09898e7 but the message is from d4ec30b2.
>
> I haven't tried bleeding edge gitk or bisecting yet. I'll let you know
> if I can track this down to a specific change.

Actually I don't think it's a gitk problem. If I run

  git diff-tree --stdin -p --pretty << EOF | less
  09898e7c3b040086e8addd4ef226548c9dce1460
  EOF

I get the wrong commit message. Looking at the release notes this has
already been fixed in 2.0.4. Sorry for the noise.

      reply	other threads:[~2014-09-03  5:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-03  5:22 gitk bug: write commit to file takes commit message from previous commit Chris Packham
2014-09-03  5:47 ` Chris Packham [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFOYHZDtaLEcdOSGA8h99rDTUzsn9z7JytgFLi-WGzZ525QkvQ@mail.gmail.com \
    --to=judge.packham@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).