From: Han-Wen Nienhuys <hanwen@google.com>
To: Elijah Conners <business@elijahpepe.com>
Cc: Junio C Hamano <gitster@pobox.com>, git <git@vger.kernel.org>
Subject: Re: [PATCH] reftable: pass pq_entry by address
Date: Tue, 13 Sep 2022 19:36:59 +0200 [thread overview]
Message-ID: <CAFQ2z_OR8uLe3rs0r09a3fvSQUE2H4WQTquddUwEeahoiRWimA@mail.gmail.com> (raw)
In-Reply-To: <18337ea407a.10c144c52599576.4708941661785569426@elijahpepe.com>
On Tue, Sep 13, 2022 at 7:34 PM Elijah Conners <business@elijahpepe.com> wrote:
>
> Junio C Hamano <gitster@pobox.com> writes:
> > Do we have any hard guidance like "do not pass an data item whose
> > size is larger than 64 bytes" in our coding guidelines? If not,
> > make sure that the reference to 64 bytes does not look like one.
> While we don't have hard guidance like that, putting an object that exceeds 64 bytes on the stack is dangerous.
it might be a bit slower, but "dangerous"? How so?
--
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Liana Sebastian
next prev parent reply other threads:[~2022-09-13 18:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 4:53 [PATCH] reftable: pass pq_entry by address Elijah Conners
2022-09-13 9:11 ` Han-Wen Nienhuys
2022-09-13 15:55 ` Junio C Hamano
2022-09-13 17:34 ` Elijah Conners
2022-09-13 17:36 ` Han-Wen Nienhuys [this message]
2022-09-13 18:03 ` Elijah Conners
2022-09-15 7:49 ` Han-Wen Nienhuys
2022-09-15 2:27 ` Junio C Hamano
2022-09-14 23:54 ` [PATCH] reftable: use const with the pq_entry param Elijah Conners
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFQ2z_OR8uLe3rs0r09a3fvSQUE2H4WQTquddUwEeahoiRWimA@mail.gmail.com \
--to=hanwen@google.com \
--cc=business@elijahpepe.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).