From: Pranit Bauva <pranit.bauva@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Diwas Joshi <dj.dij123@gmail.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH/GSoC 3/3] Nousage message in error
Date: Thu, 24 Mar 2016 21:58:09 +0530 [thread overview]
Message-ID: <CAFZEwPOd2RyfF5eMqB5XZqNg5Oc_fbDmERcOAMpgR81pmPOPQg@mail.gmail.com> (raw)
In-Reply-To: <xmqqh9fvalpm.fsf@gitster.mtv.corp.google.com>
On Thu, Mar 24, 2016 at 9:53 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Pranit Bauva <pranit.bauva@gmail.com> writes:
>
>> A general convention followed by git users it to write the commit
>> message as "What he did to the code?" rather than "What problem was
>> there in the code?"
>
> It is OK for other projects to adopt a different convention, but The
> project convention here is different.
>
> We tend to write our log message like this in this order:
>
> - Explain relevant behaviour and code structure in the current code
> to refresh memory of readers to help them understand the next two
> items better. This paragraph is optional and you see it only in
> difficult patches.
>
> - Desribe the problem. What the end user would do and what she
> sees in response to it, why that is not a good outcome, and what
> would be a better outcome. For a patch to only improve code,
> replace "the end user" with "other codepaths that interact with
> the code being changed".
>
> - Explain the approach to implement a better outcome. This
> paragraph is optional and you see it only in patches that
> implement tricky solutions.
>
> - Describe the solution, as if you are giving orders to the
> maintainers to change the code this way and that way.
Thanks for making it clearer to me! I tend to write bad commit
messages. Improving on it though.
next prev parent reply other threads:[~2016-03-24 16:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 2:03 [PATCH/GSoC 3/3] Nousage message in error Diwas Joshi
2016-03-24 5:14 ` Pranit Bauva
2016-03-24 16:23 ` Junio C Hamano
2016-03-24 16:28 ` Pranit Bauva [this message]
2016-03-24 7:24 ` Pranit Bauva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFZEwPOd2RyfF5eMqB5XZqNg5Oc_fbDmERcOAMpgR81pmPOPQg@mail.gmail.com \
--to=pranit.bauva@gmail.com \
--cc=dj.dij123@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).