From: Kato Kazuyoshi <kato.kazuyoshi@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC] gitweb: add the ability to show side-by-side diff on commitdiff.
Date: Mon, 17 Oct 2011 11:33:49 +0900 [thread overview]
Message-ID: <CAFo4x0KPP1yZec+98_rn9tG_fhtB-DYAcdi90TwiwUPq+DP90g@mail.gmail.com> (raw)
In-Reply-To: <7vbotgper8.fsf@alter.siamese.dyndns.org>
On Mon, Oct 17, 2011 at 10:51 AM, Junio C Hamano <gitster@pobox.com> wrote:
>
> I think a better organization would be
>
> [1/2] change code so that $diff_class does not have leading SP
> optionally catch a case where $diff_class stays empty as an error?
>
I think we don't have to treat empty $diff_class as an error because
$diff_class will be an empty when $line is around modification
(ex. foo or quux).
foo
- bar
+ baz
quuz
And class attributes are CDATA. "diff[SP]" and "diff" have same
meanings.
http://www.w3.org/TR/html401/struct/global.html#h-7.5.2
http://www.w3.org/TR/html401/types.html#type-cdata
--
Kato Kazuyoshi
next prev parent reply other threads:[~2011-10-17 2:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-16 23:57 [PATCH/RFC] gitweb: add the ability to show side-by-side diff on commitdiff Kato Kazuyoshi
2011-10-17 0:20 ` Junio C Hamano
2011-10-17 1:15 ` Kato Kazuyoshi
2011-10-17 1:51 ` Junio C Hamano
2011-10-17 2:33 ` Kato Kazuyoshi [this message]
2011-10-17 3:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFo4x0KPP1yZec+98_rn9tG_fhtB-DYAcdi90TwiwUPq+DP90g@mail.gmail.com \
--to=kato.kazuyoshi@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).