git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tim Henigan <tim.henigan@gmail.com>
To: David Aguilar <davvid@gmail.com>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH v3 12/9] t7800: add tests for difftool --dir-diff
Date: Thu, 22 Mar 2012 09:55:54 -0400	[thread overview]
Message-ID: <CAFouetiDZYAx0MyU310Dxke4bS36D171tzazmKJ-sb4YPR12-Q@mail.gmail.com> (raw)
In-Reply-To: <CAJDDKr7m3Ur-RNHffkW9rvbT6kpXWjKMG+Kiw5ausQw5058LHw@mail.gmail.com>

On Thu, Mar 22, 2012 at 5:53 AM, David Aguilar <davvid@gmail.com> wrote:
> On Wed, Mar 21, 2012 at 12:36 PM, Tim Henigan <tim.henigan@gmail.com> wrote:
>
> If we wrap the subdir operations in parentheses then the sub-shell
> saves us from having to do "cd ..".  It also helps prevent leakage
> from earlier failures, which is helpful when writing new tests.

I will update the patch to include this change.  Thank you for the example.


> It'd also be pretty neat if we could gather file content somehow.
> This would allow us to make assertions about the content of the
> left/right parameters passed to the tool.  I don't know if that's test
> overkill ;-) but it seems like it could be helpful.

This sounds like a good change for some future patch ;)

      reply	other threads:[~2012-03-22 13:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-21 19:35 [PATCH v3 0/9] difftool: teach command to perform directory diffs Tim Henigan
2012-03-21 19:35 ` [PATCH v3 7/9] difftool: teach difftool to handle " Tim Henigan
2012-03-21 19:35 ` [PATCH v3 8/9] difftool: teach dir-diff to copy modified files back to working tree Tim Henigan
2012-03-21 19:35 ` [PATCH v3 10/9] difftool: do not allow mix of '--prompt' with '--no-prompt' Tim Henigan
2012-03-21 20:14   ` Junio C Hamano
2012-03-22  1:53   ` [PATCH 10/9 v4] difftool: fix regression in '--prompt' options Tim Henigan
2012-03-22  4:09     ` Junio C Hamano
2012-03-22  8:19       ` Thomas Rast
2012-03-22 13:51         ` Tim Henigan
2012-03-22 16:59           ` Junio C Hamano
2012-03-22 19:01             ` Tim Henigan
2012-03-22 19:13               ` Junio C Hamano
2012-03-22 16:57         ` Junio C Hamano
2012-03-21 19:35 ` [PATCH v3 11/9] t7800: add test for difftool --tool-help Tim Henigan
2012-03-21 19:36 ` [PATCH v3 12/9] t7800: add tests for difftool --dir-diff Tim Henigan
2012-03-22  9:53   ` David Aguilar
2012-03-22 13:55     ` Tim Henigan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFouetiDZYAx0MyU310Dxke4bS36D171tzazmKJ-sb4YPR12-Q@mail.gmail.com \
    --to=tim.henigan@gmail.com \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).