From: Tim Henigan <tim.henigan@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v1 06/25] contrib: remove 'diffall'
Date: Fri, 9 May 2014 08:12:07 -0700 [thread overview]
Message-ID: <CAFouetj4A+z2xzciGAbsQ8th8CNwYMd5QTapar4TXRLzGdAqeQ@mail.gmail.com> (raw)
In-Reply-To: <1399597116-1851-7-git-send-email-felipe.contreras@gmail.com>
On Thu, May 8, 2014 at 5:58 PM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> No activity since 2010, no tests.
>
> Cc: Tim Henigan <tim.henigan@gmail.com>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
> contrib/diffall/README | 31 ------
> contrib/diffall/git-diffall | 257 --------------------------------------------
> 2 files changed, 288 deletions(-)
> delete mode 100644 contrib/diffall/README
> delete mode 100755 contrib/diffall/git-diffall
I see no problem with removing this script from contrib. However, the
commit message
should mention that git-difftool learned all the features of
git-diffall when the '--dir-diff'
option was added in v1.7.11 (ca. June 2012).
Also, the script was first added to contrib in Feb. 2012, so "no
activity since 2010" is
incorrect. I'm not sure this information is useful in the commit
message at all.
next prev parent reply other threads:[~2014-05-09 15:12 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 0:58 [PATCH v1 00/25] contrib: cleanup Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 02/25] contrib: remove 'hg-to-git' Felipe Contreras
2014-05-09 6:44 ` Miklos Vajna
2014-05-09 0:58 ` [PATCH v1 03/25] contrib: remove 'stats' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 04/25] contrib: remove 'buildsystems' Felipe Contreras
2014-05-09 7:53 ` Erik Faye-Lund
2014-05-09 8:14 ` Felipe Contreras
2014-05-09 8:33 ` Erik Faye-Lund
2014-05-09 8:48 ` Felipe Contreras
2014-05-09 9:10 ` Erik Faye-Lund
2014-05-09 9:32 ` Felipe Contreras
2014-05-09 10:02 ` Erik Faye-Lund
2014-05-09 10:57 ` Felipe Contreras
2014-05-09 11:35 ` Erik Faye-Lund
2014-05-09 9:17 ` David Kastrup
2014-05-09 9:35 ` Felipe Contreras
2014-05-09 9:44 ` David Kastrup
2014-05-09 10:50 ` Felipe Contreras
2014-05-09 11:21 ` David Kastrup
2014-05-09 18:33 ` Jonathan Nieder
2014-05-09 0:58 ` [PATCH v1 05/25] contrib: remove 'convert-objects' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 06/25] contrib: remove 'diffall' Felipe Contreras
2014-05-09 15:12 ` Tim Henigan [this message]
2014-05-09 18:50 ` Jonathan Nieder
2014-05-09 19:26 ` Tim Henigan
2014-05-09 20:12 ` Jonathan Nieder
2014-05-09 20:16 ` Tim Henigan
[not found] ` <CAFouetj=30Wd_CDiXA0UqqKNdfJSv+C5mWbMJPOkEdqxr7k54w@mail.gmail.com>
2014-05-09 15:20 ` Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 07/25] contrib: remove 'git-jump' Felipe Contreras
2014-05-09 2:03 ` Jeff King
2014-05-09 2:12 ` Felipe Contreras
2014-05-09 15:20 ` Jeff King
2014-05-09 16:13 ` Felipe Contreras
2014-05-09 17:37 ` Junio C Hamano
2014-05-09 0:58 ` [PATCH v1 08/25] contrib: remove 'git-shell-commands' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 09/25] contrib: remove 'gitview' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 10/25] contrib: reomve 'thunderbird-patch-inline' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 11/25] contrib: remove 'workdir' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 12/25] contrib: remove 'vim' Felipe Contreras
2014-05-09 2:02 ` Jeff King
2014-05-09 2:23 ` Jonathan Nieder
2014-05-09 0:58 ` [PATCH v1 13/25] contrib: remove 'svn-fe' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 14/25] contrib: remove 'rerere-train' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 15/25] contrib: remove 'remotes2config' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 16/25] contrib: remove 'persistent-https' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 17/25] contrib: remove 'git-resurrect' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 18/25] contrib: remove 'emacs' Felipe Contreras
[not found] ` <CAFcZeCqbF54-KjHU1R3pC6XgWi21KcpRGB7HcbfSGyvTScQU2A@mail.gmail.com>
2014-05-09 8:29 ` Felipe Contreras
[not found] ` <CAFcZeCo5mCfnUN1uBiaZnD6DL6y8hPhK5MPts5raLCTGwJX9Gg@mail.gmail.com>
2014-05-09 8:50 ` Felipe Contreras
2014-05-09 14:50 ` Alexandre Julliard
2014-05-09 14:53 ` Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 19/25] contrib: remove 'diff-highlight' Felipe Contreras
2014-05-09 1:51 ` Jeff King
2014-05-09 1:55 ` Felipe Contreras
2014-05-09 13:37 ` Stefan Beller
2014-05-09 14:16 ` Felipe Contreras
2014-05-09 17:04 ` Junio C Hamano
2014-05-09 17:45 ` Felipe Contreras
2014-05-09 18:06 ` Junio C Hamano
2014-05-09 18:21 ` Felipe Contreras
2014-05-09 18:29 ` Junio C Hamano
2014-05-09 18:40 ` Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 20/25] contrib: remove 'contacts' Felipe Contreras
2014-05-10 1:59 ` brian m. carlson
2014-05-10 4:00 ` Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 22/25] contrib: remove 'fast-import' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 24/25] contrib: remove 'hooks' Felipe Contreras
2014-05-09 1:47 ` [PATCH v1 00/25] contrib: cleanup Martin Langhoff
[not found] ` <CACPiFCJnsu3qw59oK94sP1u0+KBDvne0ZpKS0LMGc_9ge+rJjA@mail.gmail.com>
2014-05-09 2:01 ` Felipe Contreras
2014-05-09 13:15 ` Stefan Beller
2014-05-09 15:22 ` Jeff King
2014-05-09 15:57 ` Felipe Contreras
2014-05-09 17:09 ` Martin Langhoff
2014-05-09 17:15 ` Felipe Contreras
[not found] ` <1399597116-1851-26-git-send-email-felipe.contreras@gmail.com>
2014-05-09 10:46 ` [PATCH v1 25/25] contrib: remove 'mw-to-git' Matthieu Moy
2014-05-09 10:59 ` Felipe Contreras
2014-05-09 12:30 ` Stefan Beller
[not found] ` <1399597116-1851-24-git-send-email-felipe.contreras@gmail.com>
2014-05-09 15:00 ` [PATCH v1 23/25] contrib: remove 'hooks/multimail' Michael Haggerty
2014-05-09 15:04 ` David Kastrup
2014-05-09 15:28 ` Michael Haggerty
2014-05-09 15:18 ` Felipe Contreras
2014-05-09 16:46 ` James Denholm
2014-05-09 19:56 ` [PATCH v1 00/25] contrib: cleanup Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFouetj4A+z2xzciGAbsQ8th8CNwYMd5QTapar4TXRLzGdAqeQ@mail.gmail.com \
--to=tim.henigan@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).