git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Astril Hayato <astrilhayato@gmail.com>
To: Paul Mackerras <paulus@samba.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitk: Comply with XDG base directory specification
Date: Tue, 21 Jan 2014 17:40:58 +0000	[thread overview]
Message-ID: <CAFysofbwxb23or25vqh_JFLNU7Ksm9ch=YnvaFggPvdU_x2T7A@mail.gmail.com> (raw)
In-Reply-To: <20140121111041.GC8265@iris.ozlabs.ibm.com>

On Tue, Jan 21, 2014 at 11:10 AM, Paul Mackerras <paulus@samba.org> wrote:
>> +    if {![file exists $config_file]} {
>> +     if {![file exists [file dirname $config_file]]} {
>> +         file mkdir [file dirname $config_file]
>> +     }
>> +     # for backward compatability use the old config file if it exists
>> +     if {[file exists "~/.gitk"]} {set config_file "~/.gitk"}
>
> Don't we need to set config_file_tmp here too?

Yeah it's probably best to keep the two files together.

>
> And, do we really want to create the ~/.config/git directory if we are
> using the old-style ~/.gitk as the config file?

Probably not. I'll prepare a new patch restoring the old behaviour.

Regards,
Astril.

      reply	other threads:[~2014-01-21 17:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13 19:46 [PATCH] gitk: Comply with XDG base directory specification Astril Hayato
2014-01-21 11:10 ` Paul Mackerras
2014-01-21 17:40   ` Astril Hayato [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFysofbwxb23or25vqh_JFLNU7Ksm9ch=YnvaFggPvdU_x2T7A@mail.gmail.com' \
    --to=astrilhayato@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).