From: "Jiří Hruška" <jirka@fud.cz>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] remote-curl: avoid hang if curl asks for more data after eof
Date: Wed, 15 Nov 2023 00:16:45 +0100 [thread overview]
Message-ID: <CAGE_+C5PrqgMiyrJCSzb12ukihad5QHpwtUSpTXVbsiNWBgYuA@mail.gmail.com> (raw)
In-Reply-To: <20231113212243.1495815-1-jonathantanmy@google.com>
Thank you for the comments,
> Yes, please split non-functional changes into a separate commit
> (preferably one for each concern). I do envision reviewers saying "let's
> put patches X, Y, and Z in, but not patches A, B, and C", so splitting
> would make it easier to decide what's worthwhile to have.
Sure, will do
next prev parent reply other threads:[~2023-11-14 23:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 11:25 [PATCH] remote-curl: avoid hang if curl asks for more data after eof Jiří Hruška
2023-11-13 21:22 ` Jonathan Tan
2023-11-14 1:36 ` Junio C Hamano
2023-11-14 23:33 ` Jiří Hruška
2023-11-27 13:19 ` Jiří Hruška
2023-11-14 23:16 ` Jiří Hruška [this message]
2023-11-15 3:34 ` [PATCH v2 0/5] Avoid hang if curl needs eof twice + minor related improvements Jiří Hruška
2023-11-15 23:28 ` Jonathan Tan
2023-11-27 13:39 ` Jiří Hruška
2023-11-27 18:26 ` Jonathan Tan
[not found] ` <20231115033121.939-1-jirka@fud.cz>
2023-11-15 3:34 ` [PATCH v2 1/5] remote-curl: avoid hang if curl asks for more data after eof Jiří Hruška
2023-11-15 19:20 ` Jonathan Tan
2023-11-15 3:34 ` [PATCH v2 2/5] remote-curl: improve readability of curl callbacks Jiří Hruška
2023-11-15 3:34 ` [PATCH v2 3/5] remote-curl: simplify rpc_out() - remove superfluous ifs Jiří Hruška
2023-11-15 3:34 ` [PATCH v2 4/5] remote-curl: simplify rpc_out() - less nesting and rename Jiří Hruška
2023-11-15 3:34 ` [PATCH v2 5/5] http: reset CURLOPT_POSTFIELDSIZE_LARGE between requests Jiří Hruška
2023-11-15 6:44 ` Patrick Steinhardt
2023-11-27 13:21 ` Jiří Hruška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGE_+C5PrqgMiyrJCSzb12ukihad5QHpwtUSpTXVbsiNWBgYuA@mail.gmail.com \
--to=jirka@fud.cz \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).