From: "Jiří Hruška" <jirka@fud.cz>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Tan <jonathantanmy@google.com>,
git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] remote-curl: avoid hang if curl asks for more data after eof
Date: Wed, 15 Nov 2023 00:33:19 +0100 [thread overview]
Message-ID: <CAGE_+C7h6HOh+ptdhwJ3MNn5HWFoc1WF-foLRrew6FJEo_yupg@mail.gmail.com> (raw)
In-Reply-To: <xmqqv8a515ge.fsf@gitster.g>
> Is this a bug on our side, or cURL library calling us when it should not?
I thought the same and yes, I suppose it _might_ be potentially considered
a bug on cURL side in the first place. But then also
1/ it is not mandated anywhere in the API that the callback will never be
called again after already getting an EOF once,
2/ I looked at libcurl code and it was not entirely clear to me that the
behavior would be accidental, that it could be clearly called as a bug,
3/ anything that follows how fread() works would never be affected,
but git-remote-curl is, because it does something differently,
4/ even if it gets fixed in libcurl today, people might be building Git with
whatever old versions of the library for years to come,
so worth fixing here in any case (imho).
But I'll reach out to curl-library and get their opinion, so that we have
a full picture here. Thanks
next prev parent reply other threads:[~2023-11-14 23:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 11:25 [PATCH] remote-curl: avoid hang if curl asks for more data after eof Jiří Hruška
2023-11-13 21:22 ` Jonathan Tan
2023-11-14 1:36 ` Junio C Hamano
2023-11-14 23:33 ` Jiří Hruška [this message]
2023-11-27 13:19 ` Jiří Hruška
2023-11-14 23:16 ` Jiří Hruška
2023-11-15 3:34 ` [PATCH v2 0/5] Avoid hang if curl needs eof twice + minor related improvements Jiří Hruška
2023-11-15 23:28 ` Jonathan Tan
2023-11-27 13:39 ` Jiří Hruška
2023-11-27 18:26 ` Jonathan Tan
[not found] ` <20231115033121.939-1-jirka@fud.cz>
2023-11-15 3:34 ` [PATCH v2 1/5] remote-curl: avoid hang if curl asks for more data after eof Jiří Hruška
2023-11-15 19:20 ` Jonathan Tan
2023-11-15 3:34 ` [PATCH v2 2/5] remote-curl: improve readability of curl callbacks Jiří Hruška
2023-11-15 3:34 ` [PATCH v2 3/5] remote-curl: simplify rpc_out() - remove superfluous ifs Jiří Hruška
2023-11-15 3:34 ` [PATCH v2 4/5] remote-curl: simplify rpc_out() - less nesting and rename Jiří Hruška
2023-11-15 3:34 ` [PATCH v2 5/5] http: reset CURLOPT_POSTFIELDSIZE_LARGE between requests Jiří Hruška
2023-11-15 6:44 ` Patrick Steinhardt
2023-11-27 13:21 ` Jiří Hruška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGE_+C7h6HOh+ptdhwJ3MNn5HWFoc1WF-foLRrew6FJEo_yupg@mail.gmail.com \
--to=jirka@fud.cz \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).