From: Garrett Cooper <yaneurabeya@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 4/5] branch: mention start_name in set-upstream error messages
Date: Tue, 2 Apr 2013 12:39:48 -0700 [thread overview]
Message-ID: <CAGHfRMA8oAX-vigeYXxEVzWsrcPaWw0jCoOHWUMA-gbbAESNRA@mail.gmail.com> (raw)
In-Reply-To: <20130402190451.GD32316@sigill.intra.peff.net>
On Tue, Apr 2, 2013 at 12:04 PM, Jeff King <peff@peff.net> wrote:
> If we refuse a branch operation because the tracking
> start_name the user gave us is bogus, we just print
> something like:
>
> fatal: Cannot setup tracking information; start point is not a branch
>
> If we mention the actual name we tried to use, that may help
> the user figure out why it didn't work (e.g., if they gave
> us the arguments in the wrong order).
>
> Signed-off-by: Jeff King <peff@peff.net>
LGTM!
Reviewed-by: Garrett Cooper <yaneurabeya@gmail.com>
next prev parent reply other threads:[~2013-04-02 19:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 17:07 [BUG] inconsistent behavior with --set-upstream vs --set-upstream-to Garrett Cooper
2013-04-02 17:23 ` Jeff King
2013-04-02 17:30 ` Garrett Cooper
2013-04-02 17:51 ` Jeff King
2013-04-02 19:01 ` [RFC/PATCH 0/5] branch --set-upstream-to error-message improvements Jeff King
2013-04-02 19:02 ` [PATCH 1/5] t3200: test --set-upstream-to with bogus refs Jeff King
2013-04-02 19:03 ` [PATCH 2/5] branch: factor out "upstream is not a branch" error messages Jeff King
2013-04-02 19:36 ` Garrett Cooper
2013-04-02 19:36 ` Garrett Cooper
2013-04-02 19:04 ` [PATCH 3/5] branch: improve error message for missing --set-upstream-to ref Jeff King
2013-04-02 19:04 ` [PATCH 4/5] branch: mention start_name in set-upstream error messages Jeff King
2013-04-02 19:39 ` Garrett Cooper [this message]
2013-04-02 19:05 ` [PATCH 5/5] branch: give advice when tracking start-point is missing Jeff King
2013-04-02 21:50 ` [RFC/PATCH 0/5] branch --set-upstream-to error-message improvements Junio C Hamano
2013-04-02 19:08 ` [BUG] inconsistent behavior with --set-upstream vs --set-upstream-to Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGHfRMA8oAX-vigeYXxEVzWsrcPaWw0jCoOHWUMA-gbbAESNRA@mail.gmail.com \
--to=yaneurabeya@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).