From: M Hickford <mirth.hickford@gmail.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: M Hickford via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, M Hickford <mirth.hickford@gmail.com>
Subject: Re: [PATCH] libsecret: retrieve empty password
Date: Mon, 19 Feb 2024 20:00:00 +0000 [thread overview]
Message-ID: <CAGJzqsmwpHu7sMNs6C7k-V5JtpPtdYmXEp2uk-x-ZKLZ8S6jCA@mail.gmail.com> (raw)
In-Reply-To: <ZdLweyFLDtdMAq2x@tanuki>
> > + g_free(c->password);
> > + c->password = strdup("");
>
> Shouldn't we use `g_strdup()` here, like we do everywhere else in this
> credential helper?
You're right. I'll correct in patch v2.
next prev parent reply other threads:[~2024-02-19 20:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 22:51 [PATCH] libsecret: retrieve empty password M Hickford via GitGitGadget
2024-02-19 6:08 ` Patrick Steinhardt
2024-02-19 20:00 ` M Hickford [this message]
2024-02-19 20:40 ` [PATCH v2] " M Hickford via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGJzqsmwpHu7sMNs6C7k-V5JtpPtdYmXEp2uk-x-ZKLZ8S6jCA@mail.gmail.com \
--to=mirth.hickford@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).