From: Stefan Beller <sbeller@google.com>
To: Orgad Shaneh <orgads@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Pat Thoyts <patthoyts@users.sourceforge.net>,
git <git@vger.kernel.org>
Subject: Re: [PATCH] git-gui: Do not reset author details on amend
Date: Tue, 27 Sep 2016 10:45:59 -0700 [thread overview]
Message-ID: <CAGZ79kYYUNf7AvpQu=NzrujM6pCdBK_JunZhC-CxPkfRcNDL6g@mail.gmail.com> (raw)
In-Reply-To: <CAGHpTB+XOxMh=o_dKGx-j2P15zsmcMn0MB7BuKFksOn4O_FXYw@mail.gmail.com>
On Tue, Sep 27, 2016 at 10:23 AM, Orgad Shaneh <orgads@gmail.com> wrote:
> On Tue, Sep 27, 2016 at 7:31 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Orgad Shaneh <orgads@gmail.com> writes:
>>
>>> On Tue, Sep 27, 2016 at 12:34 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>>> Orgad Shaneh <orgads@gmail.com> writes:
>>>>
>>> I actually see that there is a problem with it:
>>> https://github.com/git-for-windows/git/issues/761
>>>
>>> I'll try to revise it and resubmit.
>>
>> Are you by chance volunteering to be git-gui maintainer?
>
> No way, sorry. I don't speak TCL at all. Every change is a true pain... ;)
I considered stepping up as an interim maintainer briefly, but this is
the exact reason
on why I punted.
Looking at e.g. `git diff --stat gitgui-0.19.0..gitgui-0.20.0` (which
is 16 month apart),
the workload seems to be very light, so I would not have concerns
w.r.t. time spent.
Stepping back a bit and asking "What does a maintainer do?" I think knowing the
language very well is not the top point, but rather looking at the design,
maintainability of proposed solutions as well as long term well being
of the project
is what makes a good maintainer.
That said I could step up as a maintainer, but for each patch I"d ask
the contributor to
find a reviewer who knows tcl well, as that is a part that I cannot
cover. And from a
contributors perspective this seems to be discouraging.
Stefan
>
> - Orgad
prev parent reply other threads:[~2016-09-27 17:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 14:23 [PATCH] git-gui: Do not reset author details on amend Orgad Shaneh
2016-05-05 17:22 ` Junio C Hamano
2016-05-18 6:12 ` Orgad Shaneh
2016-07-10 4:36 ` Orgad Shaneh
2016-09-26 20:06 ` Orgad Shaneh
2016-09-26 21:34 ` Junio C Hamano
2016-09-27 7:22 ` Orgad Shaneh
2016-09-27 16:31 ` Junio C Hamano
2016-09-27 17:23 ` Orgad Shaneh
2016-09-27 17:45 ` Stefan Beller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kYYUNf7AvpQu=NzrujM6pCdBK_JunZhC-CxPkfRcNDL6g@mail.gmail.com' \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=orgads@gmail.com \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).