From: Stefan Beller <sbeller@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [BUG] git-submodule has bash-ism?
Date: Tue, 31 May 2016 16:16:20 -0700 [thread overview]
Message-ID: <CAGZ79kYoZfwWfigUZJM9ryTSNv-WE-0owxF=iUSHsc_nQ9rWVA@mail.gmail.com> (raw)
In-Reply-To: <xmqq1t4h3jxo.fsf@gitster.mtv.corp.google.com>
On Tue, May 31, 2016 at 4:08 PM, Junio C Hamano <gitster@pobox.com> wrote:
> relative_path ()
> {
> local target curdir result
> target=$1
> curdir=${2-$wt_prefix}
>
> I am hoping that Stefan's "gradually rewrite things in C" will make
> it unnecessary to worry about this one. "git submodule" would not
> work correctly on posixly correct shells in the meantime.
noted.
Maybe as a smaller step we can expose the relative_path from the
submodule--helper
instead of rewriting all actual users first.
Thanks for pointing out,
Stefan
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-05-31 23:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 23:08 [BUG] git-submodule has bash-ism? Junio C Hamano
2016-05-31 23:16 ` Stefan Beller [this message]
2016-06-01 0:27 ` [PATCH] submodule: remove bashism from shell script Stefan Beller
2016-06-01 16:13 ` [BUG] git-submodule has bash-ism? Junio C Hamano
2016-06-01 16:19 ` Junio C Hamano
2016-06-01 16:37 ` Jeff King
2016-06-01 18:31 ` John Keeping
2016-06-01 19:07 ` Jeff King
2016-06-01 19:16 ` John Keeping
2016-06-01 19:45 ` Junio C Hamano
2016-06-01 20:28 ` John Keeping
2016-06-01 20:32 ` Jeff King
2016-06-01 20:48 ` Junio C Hamano
2016-06-01 20:56 ` Junio C Hamano
2016-06-01 20:59 ` Eric Sunshine
2016-06-01 21:08 ` Jeff King
2016-06-01 20:59 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kYoZfwWfigUZJM9ryTSNv-WE-0owxF=iUSHsc_nQ9rWVA@mail.gmail.com' \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).