compiling master fails

compiling master fails

[Stefan Beller]

On Post 2.3 cyle (batch #5) (v2.3.1-167-g7f4ba4b)

    CC http.o
http.c: In function 'get_preferred_languages':
http.c:1021:2: warning: implicit declaration of function 'setlocale'
[-Wimplicit-function-declaration]
  retval = setlocale(LC_MESSAGES, NULL);
  ^
http.c:1021:21: error: 'LC_MESSAGES' undeclared (first use in this function)
  retval = setlocale(LC_MESSAGES, NULL);
                     ^
http.c:1021:21: note: each undeclared identifier is reported only once
for each function it appears in
make: *** [http.o] Error 1

Re: compiling master fails

[Stefan Beller]

Removing config.mak makes it compile again.
config.mak contained:
CFLAGS += -Wall -g -rdynamic -O0
# CFLAGS += -Wextra
# CFLAGS += -Werror
CFLAGS += -Wno-format-zero-length
CFLAGS += -Wdeclaration-after-statement
CFLAGS += -Wpointer-arith
CFLAGS += -Wstrict-prototypes
CFLAGS += -Wold-style-declaration
# CFLAGS += -flto
# CFLAGS += -fwhole-program
CC = /usr/lib/gcc-snapshot/bin/gcc

Mind that compiling did work with this exact version of
config.mak, (I did not touch it for a few weeks now),
so I suspect new changes in changes to break the
compilation.


On Thu, Feb 26, 2015 at 12:48 PM, Stefan Beller <sbeller@google.com> wrote:
> On Post 2.3 cyle (batch #5) (v2.3.1-167-g7f4ba4b)
>
>     CC http.o
> http.c: In function 'get_preferred_languages':
> http.c:1021:2: warning: implicit declaration of function 'setlocale'
> [-Wimplicit-function-declaration]
>   retval = setlocale(LC_MESSAGES, NULL);
>   ^
> http.c:1021:21: error: 'LC_MESSAGES' undeclared (first use in this function)
>   retval = setlocale(LC_MESSAGES, NULL);
>                      ^
> http.c:1021:21: note: each undeclared identifier is reported only once
> for each function it appears in
> make: *** [http.o] Error 1

Re: compiling master fails

[Stefan Beller]

> On Thu, Feb 26, 2015 at 12:48 PM, Stefan Beller <sbeller@google.com> wrote:
>> On Post 2.3 cyle (batch #5) (v2.3.1-167-g7f4ba4b)
>>
>>     CC http.o
>> http.c: In function 'get_preferred_languages':
>> http.c:1021:2: warning: implicit declaration of function 'setlocale'
>> [-Wimplicit-function-declaration]
>>   retval = setlocale(LC_MESSAGES, NULL);
>>   ^
>> http.c:1021:21: error: 'LC_MESSAGES' undeclared (first use in this function)
>>   retval = setlocale(LC_MESSAGES, NULL);
>>                      ^
>> http.c:1021:21: note: each undeclared identifier is reported only once
>> for each function it appears in
>> make: *** [http.o] Error 1


On Thu, Feb 26, 2015 at 12:52 PM, Stefan Beller <sbeller@google.com> wrote:
> Removing config.mak makes it compile again.
> config.mak contained:
> CFLAGS += -Wall -g -rdynamic -O0
> # CFLAGS += -Wextra
> # CFLAGS += -Werror
> CFLAGS += -Wno-format-zero-length
> CFLAGS += -Wdeclaration-after-statement
> CFLAGS += -Wpointer-arith
> CFLAGS += -Wstrict-prototypes
> CFLAGS += -Wold-style-declaration
> # CFLAGS += -flto
> # CFLAGS += -fwhole-program
> CC = /usr/lib/gcc-snapshot/bin/gcc
>
> Mind that compiling did work with this exact version of
> config.mak, (I did not touch it for a few weeks now),
> so I suspect new changes in changes to break the
> compilation.
>
>


"git bisect run make" shows
f18604bbf2c391c689a41fca14cbaeff5e106255 is the first bad commit
commit f18604bbf2c391c689a41fca14cbaeff5e106255
Author: Yi EungJun <eungjun.yi@navercorp.com>
Date:   Wed Jan 28 21:04:37 2015 +0900

Is there an easy way to fix it or is my config.mak bogus now?

Re: compiling master fails

[Jonathan Nieder]

Hi,

Stefan Beller wrote:

> On Post 2.3 cyle (batch #5) (v2.3.1-167-g7f4ba4b)
>
>     CC http.o
> http.c: In function 'get_preferred_languages':
> http.c:1021:2: warning: implicit declaration of function 'setlocale'
> [-Wimplicit-function-declaration]
>   retval = setlocale(LC_MESSAGES, NULL);
>   ^

See http://thread.gmane.org/gmane.comp.version-control.git/253901/focus=264421

Thanks for reporting,
Jonathan