From: Stefan Beller <sbeller@google.com>
To: Jacob Keller <jacob.keller@gmail.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>, git <git@vger.kernel.org>,
"Jeff King" <peff@peff.net>,
"Jacob Keller" <jacob.e.keller@intel.com>,
"Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: [PATCH] coccicheck: process every source file at once
Date: Wed, 3 Oct 2018 10:54:54 -0700 [thread overview]
Message-ID: <CAGZ79kZKb_t5ALF6KPtKt05gt1jv5gZL_rrdmeO5vNAb7ed8bQ@mail.gmail.com> (raw)
In-Reply-To: <CA+P7+xpB5Pqj7Kp5HiUDqtNMiX8+kGt5QfwLaZ+ROY9jj+Xnrg@mail.gmail.com>
On Wed, Oct 3, 2018 at 8:52 AM Jacob Keller <jacob.keller@gmail.com> wrote:
>
> On Wed, Oct 3, 2018 at 8:05 AM SZEDER Gábor <szeder.dev@gmail.com> wrote:
> > In fact, it works finer than ever, because running 1.0.0 with this
> > patch on Travis CI notices a possible memmove() -> MOVE_ARRAY()
> > conversion:
> >
> > https://travis-ci.org/szeder/git/jobs/436542684#L576
> >
> > Surprisingly, running 1.0.0 without this patch, or running 1.0.4
> > locally either with or without this patch doesn't notice that
> > memmove() call. Presumably that's why Jonathan could kind-of "revert"
> > my conversion from f919ffebed (Use MOVE_ARRAY, 2018-01-22) in his
> > 6a1a79fd14 (object: move grafts to object parser, 2018-05-15) without
> > anyone noticing.
> >
>
> That seems very odd...
That looks like a bad rebase on my side as I was carrying that patch
for a while as the development of object store series took some time.
And I agree we should re-introduce the MOVE_ARRAY there.
next prev parent reply other threads:[~2018-10-03 17:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 19:16 [PATCH] coccicheck: process every source file at once Jacob Keller
2018-10-02 19:55 ` Jeff King
2018-10-02 20:00 ` Jacob Keller
2018-10-02 20:31 ` Jeff King
2018-10-02 20:58 ` Jacob Keller
2018-10-02 21:08 ` Jeff King
2018-10-03 10:16 ` SZEDER Gábor
2018-10-03 15:05 ` SZEDER Gábor
2018-10-03 15:52 ` Jacob Keller
2018-10-03 17:54 ` Stefan Beller [this message]
2018-10-03 15:51 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kZKb_t5ALF6KPtKt05gt1jv5gZL_rrdmeO5vNAb7ed8bQ@mail.gmail.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jacob.keller@gmail.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).