From: Stefan Beller <sbeller@google.com>
To: Jeff King <peff@peff.net>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 3/7] read_in_full: reset errno before reading
Date: Mon, 25 Sep 2017 17:06:58 -0700 [thread overview]
Message-ID: <CAGZ79kZwc8bNWJfH_36soy75EpyHAMbJGhQd4rV5f-0RMjiwHQ@mail.gmail.com> (raw)
In-Reply-To: <20170926000117.y3solltovyueq3zc@sigill.intra.peff.net>
On Mon, Sep 25, 2017 at 5:01 PM, Jeff King <peff@peff.net> wrote:
>
>> If you are okay with the too-long/too-short confusion in EOVERFLOW, then
>> there is EMSGSIZE:
>>
>> Message too long
>
> I don't really like that one either.
>
> I actually prefer "0" of the all of the options discussed. At least it
> is immediately clear that it is not a syscall error.
>
> -Peff
After reading this discussion from the sideline, maybe
ENODATA No message is available on the STREAM head read
queue (POSIX.1)
is not too bad after all. Or
ESPIPE Invalid seek (POSIX.1)
Technically we do not seek, but one could imagine we'd seek there
to read?
next prev parent reply other threads:[~2017-09-26 0:07 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 20:26 [PATCH 0/7] read/write_in_full leftovers Jeff King
2017-09-25 20:27 ` [PATCH 1/7] files-backend: prefer "0" for write_in_full() error check Jeff King
2017-09-25 21:59 ` Jonathan Nieder
2017-09-25 23:13 ` Jeff King
2017-09-25 20:27 ` [PATCH 2/7] notes-merge: drop dead zero-write code Jeff King
2017-09-25 21:59 ` Jonathan Nieder
2017-09-25 20:29 ` [PATCH 3/7] read_in_full: reset errno before reading Jeff King
2017-09-25 22:09 ` Jonathan Nieder
2017-09-25 23:23 ` Jeff King
2017-09-25 23:33 ` Jonathan Nieder
2017-09-25 23:37 ` Jeff King
2017-09-25 23:45 ` Jeff King
2017-09-25 23:55 ` Jonathan Nieder
2017-09-26 0:01 ` Jeff King
2017-09-26 0:06 ` Stefan Beller [this message]
2017-09-26 0:09 ` Jeff King
2017-09-26 0:16 ` Jonathan Nieder
2017-09-26 0:17 ` Jonathan Nieder
2017-09-26 0:19 ` Jeff King
2017-09-26 0:22 ` Jonathan Nieder
2017-09-26 4:11 ` Junio C Hamano
2017-09-27 4:07 ` Jeff King
2017-09-27 4:27 ` Junio C Hamano
2017-09-26 0:13 ` Jonathan Nieder
2017-09-26 0:17 ` Jeff King
2017-09-26 0:20 ` Jonathan Nieder
2017-09-26 0:25 ` Jeff King
2017-09-26 0:28 ` Jonathan Nieder
2017-09-25 23:52 ` Jonathan Nieder
2017-09-25 20:29 ` [PATCH 4/7] get-tar-commit-id: prefer "!=" for read_in_full() error check Jeff King
2017-09-25 22:10 ` Jonathan Nieder
2017-09-25 20:30 ` [PATCH 5/7] worktree: use xsize_t to access file size Jeff King
2017-09-25 22:11 ` Jonathan Nieder
2017-09-25 20:31 ` [PATCH 6/7] worktree: check the result of read_in_full() Jeff King
2017-09-25 22:14 ` Jonathan Nieder
2017-09-25 23:25 ` Jeff King
2017-09-25 20:33 ` [PATCH 7/7] add xread_in_full() helper Jeff King
2017-09-25 22:16 ` Jonathan Nieder
2017-09-25 23:27 ` Jeff King
2017-09-27 5:54 ` [PATCH v2 0/7] read/write_in_full leftovers Jeff King
2017-09-27 6:00 ` [PATCH v2 1/7] files-backend: prefer "0" for write_in_full() error check Jeff King
2017-09-27 6:00 ` [PATCH v2 2/7] notes-merge: drop dead zero-write code Jeff King
2017-09-27 6:00 ` [PATCH v2 3/7] prefer "!=" when checking read_in_full() result Jeff King
2017-09-27 6:59 ` Junio C Hamano
2017-09-27 7:09 ` Jeff King
2017-09-27 6:01 ` [PATCH v2 4/7] avoid looking at errno for short read_in_full() returns Jeff King
2017-09-27 6:59 ` Junio C Hamano
2017-09-27 6:02 ` [PATCH v2 5/7] distinguish error versus short read from read_in_full() Jeff King
2017-09-27 6:02 ` [PATCH v2 6/7] worktree: use xsize_t to access file size Jeff King
2017-09-27 6:02 ` [PATCH v2 7/7] worktree: check the result of read_in_full() Jeff King
2017-09-27 6:57 ` [PATCH v2 0/7] read/write_in_full leftovers Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kZwc8bNWJfH_36soy75EpyHAMbJGhQd4rV5f-0RMjiwHQ@mail.gmail.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).