* Feature Request: option for git difftool to show changes in submodule contents @ 2018-04-23 14:49 Oshaben Nicholas 2018-04-23 19:39 ` Stefan Beller 0 siblings, 1 reply; 2+ messages in thread From: Oshaben Nicholas @ 2018-04-23 14:49 UTC (permalink / raw) To: git@vger.kernel.org Hello, A coworker of mine was trying to use git difftool in a repository with submodules and we found that it only shows the change in the subproject commit hash. The option to show the changes in the contents of the submodules exists for git diff. Can this be added to difftool as well? Thank you, Nicholas Oshaben nicholas.oshaben@bwigroup.com ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Feature Request: option for git difftool to show changes in submodule contents 2018-04-23 14:49 Feature Request: option for git difftool to show changes in submodule contents Oshaben Nicholas @ 2018-04-23 19:39 ` Stefan Beller 0 siblings, 0 replies; 2+ messages in thread From: Stefan Beller @ 2018-04-23 19:39 UTC (permalink / raw) To: Oshaben Nicholas; +Cc: git@vger.kernel.org Hi Oshaben! On Mon, Apr 23, 2018 at 7:49 AM, Oshaben Nicholas <nicholas.oshaben@bwigroup.com> wrote: > Hello, > > A coworker of mine was trying to use git difftool in a repository with submodules and we found that it only shows the change in the subproject commit hash. The option to show the changes in the contents of the submodules exists for git diff. Can this be added to difftool as well? Yes, of course it can be added. Care to write a patch? See lines 432-443 in builtin/difftool.c: https://github.com/git/git/blob/master/builtin/difftool.c#L432 I'd think you'd want to compute some output (Similar to the git-diff output? Then we could just refactor the submodule diff stuff to be reusable here) and put it into the strbuf there. Feel free to ask away or read the docs Documentation/SubmittingPatches Thanks, Stefan ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-23 19:39 UTC | newest] Thread overview: 2+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-04-23 14:49 Feature Request: option for git difftool to show changes in submodule contents Oshaben Nicholas 2018-04-23 19:39 ` Stefan Beller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).