From: Stefan Beller <sbeller@google.com>
To: Daniel Ferreira <bnmvco@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Duy Nguyen <pclouds@gmail.com>,
Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: [PATCH v8 1/5] dir_iterator: add tests for dir_iterator API
Date: Wed, 12 Apr 2017 17:42:57 -0700 [thread overview]
Message-ID: <CAGZ79kaH0ihJ-zFX5zdK-av0Aqxi1ebCEqj5smb2Zu9pKRG8oA@mail.gmail.com> (raw)
In-Reply-To: <1491442767-54068-2-git-send-email-bnmvco@gmail.com>
On Wed, Apr 5, 2017 at 6:39 PM, Daniel Ferreira <bnmvco@gmail.com> wrote:
> +int cmd_main(int argc, const char **argv) {
Style (minor nit, in case resend is needed):
We only put the { brace on the same line for statements
(if, for, while, switch), not for function declarations.
I tried to find a good rationale for it, this is the most sufficient I
could find
https://www.kernel.org/doc/Documentation/process/coding-style.rst
(section 3):
Heretic people all over the world have claimed that this inconsistency
is ... well ... inconsistent, but all right-thinking people know that
(a) K&R are **right** and (b) K&R are right. Besides, functions are
special anyway (you can't nest them in C).
next prev parent reply other threads:[~2017-04-13 0:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 1:39 [PATCH v8 0/5] [GSoC] remove_subtree(): reimplement using iterators Daniel Ferreira
2017-04-06 1:39 ` [PATCH v8 1/5] dir_iterator: add tests for dir_iterator API Daniel Ferreira
2017-04-13 0:42 ` Stefan Beller [this message]
2017-04-06 1:39 ` [PATCH v8 2/5] remove_subtree(): test removing nested directories Daniel Ferreira
2017-04-06 1:39 ` [PATCH v8 3/5] dir_iterator: add helpers to dir_iterator_advance Daniel Ferreira
2017-04-06 1:39 ` [PATCH v8 4/5] dir_iterator: refactor state machine model Daniel Ferreira
2017-04-17 6:52 ` Michael Haggerty
2017-04-06 1:39 ` [PATCH v8 5/5] remove_subtree(): reimplement using iterators Daniel Ferreira
2017-04-13 0:06 ` [PATCH v8 0/5] [GSoC] " Daniel Ferreira (theiostream)
2017-04-13 0:50 ` Stefan Beller
2017-04-17 6:29 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kaH0ihJ-zFX5zdK-av0Aqxi1ebCEqj5smb2Zu9pKRG8oA@mail.gmail.com \
--to=sbeller@google.com \
--cc=bnmvco@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).