From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 4F7AD1F404 for ; Mon, 12 Feb 2018 19:01:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753836AbeBLTBC (ORCPT ); Mon, 12 Feb 2018 14:01:02 -0500 Received: from mail-yw0-f180.google.com ([209.85.161.180]:41175 "EHLO mail-yw0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753550AbeBLTBB (ORCPT ); Mon, 12 Feb 2018 14:01:01 -0500 Received: by mail-yw0-f180.google.com with SMTP id f12so1802780ywb.8 for ; Mon, 12 Feb 2018 11:01:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=BQjJt5k1VrYLokrjGGLmozeBIJmdDvLJhZvrCh7JyUk=; b=gFZlJD8VyOBObIPI/+wLpJCGLrUeUXMm+0ePEx6tbCgXq+Z9FIr/jYrXwW9H5lcLt6 dW80r+TftJrfnUm2I7X7dO2EOt82dQxsYO0Zry+n/kRlP5X/9grS/ll1hlR/GeM7XuYD +zY1AUEVjT2m/hcqnr0iA53gz+RP5j17rXKFCo+J50UuccW59HsIVwaeZgjL1W2v0p/0 8dapCOJ+dEJvV3ry9jqDv0Ks1OyLlsVgVe26aNp7x1vhPCnHfva65w4L0QIM6pqjXqP6 9m29o3WpDZE3/bO86KdwQFlM+piUmwdBgAbmInhzng7t9vga4i8PSNJwCf/BQmgs9KVA cnbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BQjJt5k1VrYLokrjGGLmozeBIJmdDvLJhZvrCh7JyUk=; b=Eshq0t+T+iMf8v4rczcIptViX7ZjHvncaMc6xwkmBcl6OAiMHuCe4Ifll2BnWVrAE5 YN17NtLXmcjDJumz2I6229ggDfsVdzOnZ1R8DpnQ/4r8mvq/BElcsPY6Akhup8SjoL09 8QTpljdFgN1eYtFiLV7PM16QS+NJr9yjzFoJwIxQTs2gRBQFtQsYwFDIhR3TjdQqjQlG cLbX8AEePp3+ZeAoI4D+rOgNI+T2dTrFUPIe+am7LXx620z+uTttPW4lTB/LFafw8bUn T1cIZGmhbdJVQ/76HHbw86K2iBiin+6kt16L2XAMTDOJ+N9xDP6mJOhk/eKdGoyblpzN 81eg== X-Gm-Message-State: APf1xPBnulC8sdyyBlRC5RdNsu4kP7tiOoiKU1wQEuUB9+8k6Dv1yVUE JWEIQyLZUqJRoqCRy5C0A1y8u55NM9Wb6q/Je7Am6w== X-Google-Smtp-Source: AH8x226EAuYJ/POVeeb5v5EQsUlrex+hwGz6E2F70WXzz0XUHmcRZZRi99nILNAFaYtW/Q/EybNX83f9+wDX7p9Guwg= X-Received: by 10.129.11.8 with SMTP id 8mr8433145ywl.156.1518462060121; Mon, 12 Feb 2018 11:01:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.207.203 with HTTP; Mon, 12 Feb 2018 11:00:59 -0800 (PST) In-Reply-To: References: <20180205235508.216277-1-sbeller@google.com> <20180205235508.216277-4-sbeller@google.com> From: Stefan Beller Date: Mon, 12 Feb 2018 11:00:59 -0800 Message-ID: Subject: Re: [PATCH 003/194] object-store: move packed_git and packed_git_mru to object store To: Junio C Hamano Cc: git , Jonathan Nieder , =?UTF-8?Q?Ren=C3=A9_Scharfe?= Content-Type: text/plain; charset="UTF-8" Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Feb 9, 2018 at 2:09 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Patch generated by >> >> 2. Applying the semantic patch contrib/coccinelle/packed_git.cocci >> to adjust callers. > > About this part... > >> diff --git a/contrib/coccinelle/packed_git.cocci b/contrib/coccinelle/packed_git.cocci >> new file mode 100644 >> index 0000000000..da317a51a9 >> --- /dev/null >> +++ b/contrib/coccinelle/packed_git.cocci >> @@ -0,0 +1,7 @@ >> +@@ @@ >> +- packed_git >> ++ the_repository->objects.packed_git >> + >> +@@ @@ >> +- packed_git_mru >> ++ the_repository->objects.packed_git_mru > > The above is correct for one-time transition turning pre-transition > code to post the_repository world, but I am not sure if we want to > have it in contrib/coccinelle/, where "make coccicheck" looks at, as > a way to continuously keep an eye on "style" violations like using > strbuf_addf() for a constant when strbuf_addstr() suffices. > > Wouldn't we need a mechanism to ensure that this file will *not* be > used in "make coccicheck" somehow? > I can omit the cocci files from the patches, if that is better for maintenance. I thought it may be a helpful for merging this series with the rest of the evolved code base which may make use of one of the converted functions. So instead of fixing that new instance manually, cocinelle could do that instead. Stefan