From: Stefan Beller <sbeller@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Phillip Wood <phillip.wood@dunelm.org.uk>, git <git@vger.kernel.org>
Subject: Re: [PATCH] diff: fix --color-moved-ws=allow-indentation-change
Date: Tue, 11 Sep 2018 11:40:12 -0700 [thread overview]
Message-ID: <CAGZ79kacqst9PVCzit_XpKYTHDC7VaKG_7OGoZyd3CtUxw74Cg@mail.gmail.com> (raw)
In-Reply-To: <xmqqftyfq4qw.fsf@gitster-ct.c.googlers.com>
On Tue, Sep 11, 2018 at 11:16 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> Stefan Beller <sbeller@google.com> writes:
>
> >> [...] So this should be sufficient.
> >
> > Yup.
> > Thanks for keeping track of this patch, as I lost track of it.
> >
> > thanks,
> > Stefan
>
> So does the above exchange mean that
> <20180904135258.31300-1-phillip.wood@talktalk.net> is ready to go
> with your Acked-by?
Acked-by: Stefan Beller <sbeller@google.com
I thought this was implicit, would you be interested in a more formal
communication for this, c.f.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n513
sections 12 and 13.
thanks.
next prev parent reply other threads:[~2018-09-11 18:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 13:52 [PATCH] diff: fix --color-moved-ws=allow-indentation-change Phillip Wood
2018-09-04 18:08 ` Stefan Beller
2018-09-04 18:51 ` Phillip Wood
2018-09-11 10:05 ` Phillip Wood
2018-09-11 17:48 ` Stefan Beller
2018-09-11 18:16 ` Junio C Hamano
2018-09-11 18:40 ` Stefan Beller [this message]
2018-09-11 19:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kacqst9PVCzit_XpKYTHDC7VaKG_7OGoZyd3CtUxw74Cg@mail.gmail.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).